Conversation
|
run-ci |
|
There was a problem hiding this comment.
Isaac Lab Review Bot
The Newton deformable implementation is moved from contrib into isaaclab_newton.assets.deformable_object, with VBD now registering its builder callback directly. The relocated asset and data paths preserve the existing implementation, while documented class imports remain available through deprecated contrib re-exports.
- Design and architecture: Ownership now aligns the deformable asset, buffers, kernels, and VBD lifecycle integration within the Newton package, removing Newton’s optional contrib dependency. The direct callback registration remains idempotent and teardown is delegated to the existing
NewtonManager.clear()lifecycle. - API: The documented
DeformableObjectandDeformableObjectDatacompatibility imports are preserved and migration guidance points users toisaaclab_newton.assets; the backend-independent asset API remains unchanged. The removed registry and hook-management functions were lower-level implementation constructs rather than documented public exports, and all repository consumers shown in the patch migrate with the ownership change. - Implementation: The moved asset and data implementations retain the existing nodal-state, cache-invalidation, registration, and simulation-binding behavior, with imports adjusted to the Newton-local manager and kernels. The VBD manager now owns registry initialization and callback registration without the previous optional-import path.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
|
run-ci |
|
run-ci |
|
run-ci |
|
CI fixes: corrected scene/timeline fixtures for declared-plan ownership; restricted clone label rebasing to entity labels (the broader match disconnected tendon actuator target references); selected CUDA capture mode from Kit runtime presence, not whether a consumer needs USD. The unchanged Anymal golden now passes, as do both CPU/GPU tendon cases, all 193 manager tests, and the focused scene/timeline/cloner checks. No golden-image or threshold changes. |
|
run-ci |
|
run-ci |
|
run-ci |
|
run-ci |
|
run-ci |
|
@mmichelis could you review this? |
Summary
Newton deformable assets now live in
isaaclab_newton, alongside Newton articulations and rigid objects. Prototype import and replication belong to the cloner; asset initialization selects the resulting native particle ranges.ClonePlan.cfgsretains the asset and sensor declarations. Backend imports use those declarations and the plan's prototype/shared roots.add_deformable_from_usd(builder, stage, root_path=...)imports the declared prototype's geometry and material before normal builder replication. Deformable and MPM asset constructors no longer register cloning work with the physics manager.Migration
Breaking:
isaaclab_contrib.deformablewas removed. Import Newton-specific deformable classes fromisaaclab_newton.assetsinstead. The backend-neutralisaaclab.assets.DeformableObjectandDeformableObjectCfgAPIs are unchanged.ClonePlan.cfg_rowsandClonePlan.context_rowsare nowcfg_source_indicesandcontext_source_indices. Both mappings contain indices intoplan.sources;plan.cfgsretains the original declarations, not copies.The local USD importer remains necessary until Newton provides the required material import and finalized deformable selection metadata. The removal conditions are documented beside the implementation; related tracking issue: #6208.
Validation
Checklist