Conversation
kellyguo11
approved these changes
Sep 1, 2026
Contributor
|
do you want to land this on develop? |
…n-tablecloth-demos # Conflicts: # source/isaaclab_newton/isaaclab_newton/physics/vbd_manager.py # source/isaaclab_newton/test/physics/test_vbd_core.py
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds one focused Newton VBD tablecloth comparison implemented with Isaac Lab's direct-workflow APIs:
scripts/demos/newton_tablecloth.pyruns the classic trick at five pull speeds, arranged side by side in one scene.The scene is declared with
InteractiveSceneCfg, uses the default Isaac Lab ground plane, and follows the normal scene write/step/update lifecycle. SimReady kitchen-island and tableware assets provide the visuals, while measured analytic collision proxies keep rigid-soft contact inexpensive and robust. The tableware retains realistic masses; the contact and cloth discretization are tuned instead of making the props artificially heavy.This remains a standalone demo because it is a deterministic side-by-side solver/contact comparison rather than a reusable agent task. The H1 manipulation workflow has intentionally been split out of this PR and converted into a registered manager-based task on a follow-up branch.
The demo defaults to the lightweight Newton GL viewer, supports the standard launcher visualizers, and uses Isaac Lab's existing video recorder with
--video. No recorder API, bitrate override, or dependency is added.Performance and solver updates
RigidObjectCollectionand keeps per-frame pull state GPU-resident.The VBD public API addition is deliberately limited to
rigid_compliant_alm, which this demo uses directly. Body-body contact capacity and AVBD stabilization remain owned by #7913; unused rigid-joint stiffness/damping fields were removed from this PR. Defaults and the compliant-ALM override are tested by constructing the real CPUSolverVBD, rather than only mocking argument forwarding.Documentation
Type of change
Validation
origin/develop(83df17e88).240frames).12 passedin the Newton VBD core tests, including real-solver default and compliant-ALM construction.3 passed, 1 skipped, 434 deselectedin the focused deformable/standalone contract checks; the skipped case requires a GUI.current-docsbuild completed without warnings.uv run isaaclab -fpassed all hooks with the changelog base set todevelop.Checklist
CONTRIBUTORS.md.