Skip to content

[eas-cli] Add --ssh to workflow:run - #4033

Open
gwdp wants to merge 2 commits into
gwdp/eng-24550-workflow-ssh-commandfrom
gwdp/eng-24550-workflow-run-ssh-flag
Open

[eas-cli] Add --ssh to workflow:run#4033
gwdp wants to merge 2 commits into
gwdp/eng-24550-workflow-ssh-commandfrom
gwdp/eng-24550-workflow-run-ssh-flag

Conversation

@gwdp

@gwdp gwdp commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Why

Lets you enable SSH when starting a run, so you can connect to it afterwards with eas workflow:ssh:

eas workflow:run --ssh

How

Adds --ssh and --ssh-idle-timeout to workflow:run, feeding a single SSH input on both run-creation mutations that marks the run's VM jobs as SSH-enabled.

  • --ssh-idle-timeout without --ssh is rejected.
  • The server owns the timeout default and clamp.

Test Plan

Unit tests cover input resolution, including the timeout-without---ssh rejection. CI passes.

@linear-code

linear-code Bot commented Jul 16, 2026

Copy link
Copy Markdown

ENG-24550

gwdp commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.22%. Comparing base (5e7dc01) to head (b08536e).

Additional details and impacted files
@@                           Coverage Diff                           @@
##           gwdp/eng-24550-workflow-ssh-command    #4033      +/-   ##
=======================================================================
+ Coverage                                64.09%   64.22%   +0.14%     
=======================================================================
  Files                                     1036     1036              
  Lines                                    47939    47947       +8     
  Branches                                 10086    10089       +3     
=======================================================================
+ Hits                                     30722    30791      +69     
+ Misses                                   17116    17055      -61     
  Partials                                   101      101              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 1f547bf to 778203e Compare July 16, 2026 19:05
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch 2 times, most recently from f3f63db to b3131bb Compare July 16, 2026 22:18
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 778203e to 5d9f23c Compare July 16, 2026 22:18
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from b3131bb to cc50b51 Compare July 16, 2026 22:20
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 5d9f23c to 12588a3 Compare July 16, 2026 22:20
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from cc50b51 to 4d9be2c Compare July 17, 2026 02:37
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 12588a3 to 0a9a189 Compare July 17, 2026 02:37
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 4d9be2c to 43999d9 Compare July 21, 2026 02:08
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 0a9a189 to dc55796 Compare July 21, 2026 02:08
@gwdp gwdp changed the title [eas-cli] add --ssh to workflow:run [eas-cli] Add --ssh to workflow:run Jul 21, 2026
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 43999d9 to 8202db4 Compare July 24, 2026 00:52
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from dc55796 to deb43f4 Compare July 24, 2026 00:52
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 8202db4 to cfc70cd Compare July 24, 2026 00:59
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from deb43f4 to 4d2e205 Compare July 24, 2026 00:59
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from cfc70cd to 89f3fb3 Compare July 24, 2026 03:10
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 4d2e205 to 0cdf1c8 Compare July 24, 2026 03:10
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 89f3fb3 to f217bca Compare July 24, 2026 03:13
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 0cdf1c8 to 0c00c05 Compare July 24, 2026 03:13
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from f217bca to 7e99ecc Compare July 24, 2026 03:28
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 0c00c05 to 950079b Compare July 24, 2026 03:28
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 7e99ecc to 1d1d365 Compare July 24, 2026 03:37
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 950079b to fa4abf9 Compare July 24, 2026 03:37
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from c24a08c to 0160476 Compare July 25, 2026 03:42
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from c11be83 to bf20956 Compare July 25, 2026 04:15
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 0160476 to 97db17f Compare July 25, 2026 04:15
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from bf20956 to 183cc2a Compare July 25, 2026 04:17
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 97db17f to 633d69e Compare July 25, 2026 04:17
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 183cc2a to 344193c Compare July 25, 2026 04:22
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch 2 times, most recently from c6eb627 to 4ff20d9 Compare July 25, 2026 04:30
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 344193c to 50cd356 Compare July 25, 2026 04:30
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 4ff20d9 to 447f3d0 Compare July 25, 2026 04:30
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from da84062 to d347f19 Compare July 25, 2026 04:37
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 447f3d0 to a182445 Compare July 25, 2026 04:37
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from d347f19 to fdc8d1d Compare July 25, 2026 04:41
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from a182445 to ae3b23f Compare July 25, 2026 04:41
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from fdc8d1d to 7acc859 Compare July 25, 2026 04:42
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from ae3b23f to 6af4e9c Compare July 25, 2026 04:42
@gwdp
gwdp changed the base branch from gwdp/eng-24550-workflow-ssh-command to graphite-base/4033 July 27, 2026 00:23
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 6af4e9c to 210e241 Compare July 27, 2026 00:33
@gwdp
gwdp force-pushed the graphite-base/4033 branch from 7acc859 to 823faef Compare July 27, 2026 00:33
@gwdp
gwdp changed the base branch from graphite-base/4033 to gwdp/eng-24550-workflow-ssh-command July 27, 2026 00:33
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 823faef to a0082de Compare July 27, 2026 00:49
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 210e241 to 9046137 Compare July 27, 2026 00:49
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from a0082de to 8285571 Compare July 28, 2026 01:05
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 9046137 to 448943f Compare July 28, 2026 01:05
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 8285571 to 3f76494 Compare July 28, 2026 23:50
import { enableJsonOutput, printJsonOnlyOutput } from '../../utils/json';
import { WorkflowFile } from '../../utils/workflowFile';

export function resolveWorkflowRunSshInput({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personal preference: inline

gwdp added 2 commits August 20, 2026 16:54
Staging schema does not include the --ssh input yet (universe #29128),
but the CLI stack already depends on it. Keep the types until that ships.
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants