[worker] Wire SSH session into build by gwdp · Pull Request #4031 · expo/eas-cli

gwdp · 2026-07-16T16:18:20Z

Why

Wiring SSH into the worker build lifecycle: when a job has SSH enabled, open the session in SSH_SESSION and keep the VM up until supervision says it is safe to tear down.

How

Start the session early in build(), pass a hasJobFinished signal into the supervisor, and await teardown in finally
Leave SSH_SESSION open in the log UI for the life of the tunnel (doNotMarkEnd, emit END on teardown)
Opening the session is best-effort: failure warns and the job continues without SSH
Upterm comes from PATH (image bake) or a runtime download from gs://turtle-v2/upterm via build-tools; this PR does not vendor binaries into the worker package

Test Plan

Worker unit tests for the SSH phase. CI

linear-code · 2026-07-16T16:18:23Z

ENG-24547

gwdp · 2026-07-16T16:18:33Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2026-07-16T16:24:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.97%. Comparing base (37ebacc) to head (0c6efc0).

Additional details and impacted files

@@                            Coverage Diff                             @@
##           gwdp/eng-24547-build-tools-ssh-session    #4031      +/-   ##
==========================================================================
+ Coverage                                   63.95%   63.97%   +0.03%     
==========================================================================
  Files                                        1033     1034       +1     
  Lines                                       47747    47778      +31     
  Branches                                    10043    10046       +3     
==========================================================================
+ Hits                                        30530    30561      +31     
  Misses                                      17116    17116              
  Partials                                      101      101

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sjchmiela

ugh sorry i had this review from 4 days ago not sent

sjchmiela

this is good, i think the code layout due to the stack nature of the feature has grown a bit too wide, but it looks great

sjchmiela · 2026-08-10T10:07:30Z

+        done = (async () => {
+          let result = BuildPhaseResult.SUCCESS;
+          try {
+            await TurtleSshSession.superviseSshSessionAsync({


maybe the supervisesshsessionasync should be inlined here?

or at least in this file

Leaning toward keeping it as its own function on purpose. The full supervise loop has its own unit tests but also would bloat this file. Let me know if you are soft on this 🙇‍♂️

Same anti-flatten object wrapper; clearer that callers await tunnel teardown.

build-tools resolves upterm from PATH or downloads darwin-arm64 / linux-amd64 from gs://turtle-v2/upterm at runtime.

github-actions · 2026-08-20T23:55:37Z

✅ Thank you for adding the changelog entry!

gwdp mentioned this pull request Jul 16, 2026

[eas-build-job] Add SSH build phase #4029

Merged

This was referenced Jul 16, 2026

[build-tools] Add worker-side SSH session helper #4030

Open

[eas-cli] Add workflow:ssh command #4032

Open

[eas-cli] Add --ssh to workflow:run #4033

Open

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from 38b2178 to d311a40 Compare July 16, 2026 19:05

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch 2 times, most recently from 534b4f1 to a7b6154 Compare July 16, 2026 22:18

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from d311a40 to 1bf156f Compare July 16, 2026 22:18

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from a7b6154 to c9e54b9 Compare July 16, 2026 22:20

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch 2 times, most recently from c1bfc6f to f7e016d Compare July 17, 2026 02:37

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch 2 times, most recently from 12f0a14 to 12feb7a Compare July 21, 2026 02:08

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from f7e016d to c590f2f Compare July 21, 2026 02:08

gwdp changed the title ~~[worker] wire ssh session into build~~ [worker] Wire SSH session into build Jul 21, 2026

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from 12feb7a to cb90fa2 Compare July 24, 2026 00:52

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from c590f2f to f04922c Compare July 24, 2026 00:52

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from cb90fa2 to 9409c52 Compare July 24, 2026 00:58

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from f04922c to 1c89f46 Compare July 24, 2026 00:58

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from 9409c52 to daee76d Compare July 24, 2026 03:10

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from 1c89f46 to 3e17793 Compare July 24, 2026 03:10

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from daee76d to 7154d05 Compare July 24, 2026 03:13

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from 3e17793 to 1e58c28 Compare July 24, 2026 03:13

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from 7154d05 to 420bbef Compare July 24, 2026 03:28

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from 1e58c28 to aff1e33 Compare July 24, 2026 03:28

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from 420bbef to 3dc29fa Compare July 24, 2026 03:37

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from aff1e33 to 8fe0c84 Compare July 24, 2026 03:37

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from de1bff6 to f6de25e Compare July 25, 2026 04:41

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch 2 times, most recently from 0297f39 to 0859dec Compare July 25, 2026 04:42

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from d5d5f1a to c4bce9c Compare July 27, 2026 00:23

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from 0859dec to bb0577f Compare July 27, 2026 00:24

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch from c4bce9c to 2aa0559 Compare July 27, 2026 00:49

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from bb0577f to 81a5ffa Compare July 27, 2026 00:49

gwdp mentioned this pull request Jul 27, 2026

[eas-build-job] Add optional ssh field on job payloads #4083

Merged

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from 81a5ffa to 0eabaa0 Compare July 28, 2026 01:05

sjchmiela requested changes Jul 28, 2026

View reviewed changes

Comment thread packages/worker/package.sh Outdated

Comment thread packages/worker/package.sh Outdated

Comment thread packages/worker/package.sh Outdated

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch 4 times, most recently from 7149fa3 to 62efd17 Compare July 28, 2026 23:56

gwdp requested a review from sjchmiela July 29, 2026 00:11

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch from 62efd17 to 7b94ba2 Compare July 29, 2026 00:22

gwdp force-pushed the gwdp/eng-24547-build-tools-ssh-session branch 2 times, most recently from 2e5bca4 to 61e8f23 Compare August 3, 2026 20:12

gwdp force-pushed the gwdp/eng-24547-worker-ssh-phase branch 4 times, most recently from 4206350 to 2dad43c Compare August 3, 2026 23:00

sjchmiela approved these changes Aug 10, 2026

View reviewed changes

gwdp added 6 commits August 20, 2026 16:54

[worker] wire ssh session into build

64b264a

Rename SSH phase sessionPromise to done.

6f70453

Same anti-flatten object wrapper; clearer that callers await tunnel teardown.

Cover SSH phase supervise callbacks and teardown failure paths.

51a67d0

[worker] Stop baking upterm into the worker package

0209fca

build-tools resolves upterm from PATH or downloads darwin-arm64 / linux-amd64 from gs://turtle-v2/upterm at runtime.

[worker] align ssh phase with build-tools api

ff8e4b6

[worker] build the ssh target from the job type

0c6efc0

Navigation Menu

Uh oh!

[worker] Wire SSH session into build - #4031

[worker] Wire SSH session into build#4031
gwdp wants to merge 6 commits into
gwdp/eng-24547-build-tools-ssh-sessionfrom
gwdp/eng-24547-worker-ssh-phase

gwdp commented Jul 16, 2026 •

edited

Loading

Uh oh!

linear-code Bot commented Jul 16, 2026

Uh oh!

gwdp commented Jul 16, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

sjchmiela left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sjchmiela left a comment

Uh oh!

Uh oh!

sjchmiela Aug 10, 2026

Uh oh!

sjchmiela Aug 10, 2026

Uh oh!

gwdp Aug 15, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

gwdp commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

How

Test Plan

Uh oh!

linear-code Bot commented Jul 16, 2026

Uh oh!

gwdp commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sjchmiela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sjchmiela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sjchmiela Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

sjchmiela Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

gwdp Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gwdp commented Jul 16, 2026 •

edited

Loading

gwdp commented Jul 16, 2026 •

edited

Loading

codecov Bot commented Jul 16, 2026 •

edited

Loading