Skip to content

[eas-build-job] Add SSH build phase - #4029

Merged
gwdp merged 1 commit into
mainfrom
gwdp/eng-24547-eas-build-job-ssh
Jul 29, 2026
Merged

[eas-build-job] Add SSH build phase#4029
gwdp merged 1 commit into
mainfrom
gwdp/eng-24547-eas-build-job-ssh

Conversation

@gwdp

@gwdp gwdp commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Why

First PR in the worker SSH stack (ENG-24547). An SSH session needs its own build phase so it shows up as a distinct step in the build logs and on the website instead of being folded into an unrelated phase.

How

Adds an SSH_SESSION entry to the BuildPhase enum, with its log display name and website id. No runtime behavior yet; later PRs in the stack use the phase.

Test Plan

Enum addition with no runtime behavior. CI passes.

@linear-code

linear-code Bot commented Jul 16, 2026

Copy link
Copy Markdown

ENG-24547

gwdp commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.27%. Comparing base (379ed8f) to head (8297089).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4029      +/-   ##
==========================================
+ Coverage   62.27%   62.27%   +0.01%     
==========================================
  Files         994      994              
  Lines       44732    44733       +1     
  Branches     9412     9412              
==========================================
+ Hits        27851    27852       +1     
  Misses      15434    15434              
  Partials     1447     1447              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp force-pushed the gwdp/eng-24547-eas-build-job-ssh branch 3 times, most recently from 19047e6 to 1277e59 Compare July 21, 2026 02:08
@gwdp gwdp changed the title [eas-build-job] add SSH_SESSION build phase [eas-build-job] Add SSH_SESSION build phase Jul 21, 2026
@gwdp
gwdp force-pushed the gwdp/eng-24547-eas-build-job-ssh branch from 1277e59 to 1c822ac Compare July 24, 2026 00:52
@gwdp
gwdp requested a review from sjchmiela July 24, 2026 03:01
@gwdp
gwdp marked this pull request as ready for review July 24, 2026 03:01

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@gwdp
gwdp force-pushed the gwdp/eng-24547-eas-build-job-ssh branch 2 times, most recently from 45758d8 to 3906608 Compare July 24, 2026 03:13
Comment thread packages/eas-build-job/src/logs.ts Outdated
@gwdp
gwdp force-pushed the gwdp/eng-24547-eas-build-job-ssh branch 5 times, most recently from fb94788 to 88f6a3b Compare July 27, 2026 00:23
@gwdp gwdp changed the title [eas-build-job] Add SSH_SESSION build phase [eas-build-job] Add SSH build phase Jul 29, 2026
@gwdp
gwdp force-pushed the gwdp/eng-24547-eas-build-job-ssh branch from 88f6a3b to 8297089 Compare July 29, 2026 22:13
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@gwdp
gwdp merged commit b0a4838 into main Jul 29, 2026
12 checks passed
@gwdp
gwdp deleted the gwdp/eng-24547-eas-build-job-ssh branch July 29, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants