Skip to content

refactor(pathfind): Optimize pathfind snippets for higher performance #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Skyaero42 wants to merge 3 commits into
base: main
Choose a base branch
from
+18 −40
Open

refactor(pathfind): Optimize pathfind snippets for higher performance #3198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be212f4
refactor(pathfind): Optimize appending node to end of the path (#3198)
Skyaero42 Aug 24, 2026
dac4aa9
refactor(pathfind): Take parents cell's position outside of for-loop …
Skyaero42 Aug 25, 2026
65c9a50
refactor(pathfind): Remove redundant isCrusher recomputation for opti…
Skyaero42 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Core/GameEngine/Include/GameLogic/AIPathfind.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,6 @@ class PathNode : public MemoryPoolObject
/// given a list, prepend this node, return new list
PathNode *prependToList( PathNode *list );

/// given a list, append this node, return new list. slow implementation.
/// @todo optimize this
PathNode *appendToList( PathNode *list );

/// given a node, append to this node
void append( PathNode *list );

Expand Down
54 changes: 18 additions & 36 deletions Core/GameEngine/Source/GameLogic/AI/AIPathfind.cpp
View file
Open in desktop

@xezon xezon Sep 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit titles say "refactor" instead of "perf"

Original file line number Diff line number Diff line change
Expand Up @@ -173,28 +173,6 @@ PathNode *PathNode::prependToList( PathNode *list )
return this;
}

//-----------------------------------------------------------------------------------
/// given a list, append this node, return new list. slow implementation.
/// @todo optimize this
PathNode *PathNode::appendToList( PathNode *list )
{
if (list == nullptr)
{
m_next = nullptr;
m_prev = nullptr;
return this;
}

PathNode *tail;
for( tail = list; tail->m_next; tail = tail->m_next )
;

tail->m_next = this;
m_prev = tail;
m_next = nullptr;

return list;
}

//-----------------------------------------------------------------------------------
/// given a node, append new node to this.
Expand Down Expand Up @@ -437,9 +415,17 @@ void Path::appendNode( const Coord3D *pos, PathfindLayerEnum layer )
node->setPosition( pos );
node->setLayer(layer);

m_path = node->appendToList( m_path );
if (!m_path)
{
m_path = node;
m_pathTail = node;

if (m_isOptimized && m_pathTail)
return;
}

m_pathTail->append(node);

if (m_isOptimized)
{
m_pathTail->setNextOptimized(node);
}
Expand Down Expand Up @@ -6184,6 +6170,7 @@ struct ExamineCellsStruct
const LocomotorSet *theLoco;
Bool centerInCell;
Bool isHuman;
Bool isCrusher;
Int radius;
const Object *obj;
PathfindCell *goalCell;
Expand All @@ -6192,10 +6179,9 @@ struct ExamineCellsStruct
/*static*/ Int Pathfinder::examineCellsCallback(Pathfinder* pathfinder, PathfindCell* from, PathfindCell* to, Int to_x, Int to_y, void* userData)
{
ExamineCellsStruct* d = (ExamineCellsStruct*)userData;
Bool isCrusher = d->obj ? d->obj->getCrusherLevel() > 0 : false;
if (d->thePathfinder->m_isTunneling) return 1; // abort.

@Caball009 Caball009 Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check necessary? Could maybe be changed to an assertion given that it's already checked at the call site.

@Skyaero42 Skyaero42 Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment it is not necessary but removing this won't give any measurable performance boost, so I would say out of scope.

I think it fits more with a refactor of the pathfinding code that Mauller and I are planning to do.

if (from && to) {
if (!d->thePathfinder->validMovementPosition( isCrusher, d->theLoco->getValidSurfaces(), to, from )) {
if (!d->thePathfinder->validMovementPosition( d->isCrusher, d->theLoco->getValidSurfaces(), to, from )) {
return 1;
}
if ( (to->getLayer() == LAYER_GROUND) && !d->thePathfinder->m_zoneManager.isPassable(to_x, to_y) ) {
Expand Down Expand Up @@ -6297,6 +6283,7 @@ Int Pathfinder::examineNeighboringCells(PathfindCell *parentCell, PathfindCell *
info.radius = radius;
info.obj = obj;
info.isHuman = isHuman;
info.isCrusher = isCrusher;
info.goalCell = goalCell;
ICoord2D start, end;
start.x = parentCell->getXIndex();
Expand All @@ -6322,6 +6309,11 @@ Int Pathfinder::examineNeighboringCells(PathfindCell *parentCell, PathfindCell *

UnsignedInt newCostSoFar = 0;

Coord3D fromPos;
fromPos.x = parentCell->getXIndex() * PATHFIND_CELL_SIZE_F ;
fromPos.y = parentCell->getYIndex() * PATHFIND_CELL_SIZE_F ;
fromPos.z = TheTerrainLogic->getGroundHeight(fromPos.x , fromPos.y);
Comment thread
qodo-free-for-open-source-projects[bot] marked this conversation as resolved.

for( int i=0; i<numNeighbors; i++ )
{
neighborFlags[i] = false;
Expand Down Expand Up @@ -6360,11 +6352,6 @@ Int Pathfinder::examineNeighboringCells(PathfindCell *parentCell, PathfindCell *
// do the gravity check here
if ( locomotorSet.isDownhillOnly() )
{
Coord3D fromPos;
fromPos.x = parentCell->getXIndex() * PATHFIND_CELL_SIZE_F ;
fromPos.y = parentCell->getYIndex() * PATHFIND_CELL_SIZE_F ;
fromPos.z = TheTerrainLogic->getGroundHeight(fromPos.x , fromPos.y);

Coord3D toPos;
Comment thread
Skyaero42 marked this conversation as resolved.
toPos.x = newCellCoord.x * PATHFIND_CELL_SIZE_F ;
toPos.y = newCellCoord.y * PATHFIND_CELL_SIZE_F ;
Expand Down Expand Up @@ -6430,11 +6417,6 @@ Int Pathfinder::examineNeighboringCells(PathfindCell *parentCell, PathfindCell *
}

if (newCell->getType() == PathfindCell::CELL_CLIFF && !newCell->getPinched() ) {
Coord3D fromPos;
fromPos.x = parentCell->getXIndex() * PATHFIND_CELL_SIZE_F ;
fromPos.y = parentCell->getYIndex() * PATHFIND_CELL_SIZE_F ;
fromPos.z = TheTerrainLogic->getGroundHeight(fromPos.x , fromPos.y);

Coord3D toPos;
toPos.x = newCellCoord.x * PATHFIND_CELL_SIZE_F ;
toPos.y = newCellCoord.y * PATHFIND_CELL_SIZE_F ;
Expand Down
Loading