Replay playback continues when the map is missing and reports a CRC mismatch

[bobtista]

Playing back a replay whose map is not installed does not fail. The game loads, plays, and reports a CRC mismatch a few frames in. That looks identical to a real desync, so it sends you hunting for a simulation bug that is not there.

Repro

1. Take a replay recorded on a user map (M=userdata/maps/<name> in the header).
2. Make sure that map is not installed.
3. generalszh.exe -headless -replay "<file>.rep"

Result: Could not find map "<path>", then CRC Mismatch in Frame 110. Playback carries on regardless.

Expected: playback stops with a clear error naming the missing map.

Suggested fix

Fail when TheMapCache->findMap returns NULL instead of carrying on with defaults. The replay header already stores the map CRC and size (MC= and MS=), so playback could also check the installed map matches the recording.

[Caball009]

This is the result I get for the GR1 with the weekly release build:

Simulating Replay "!Golden Replay #1.rep"
Could not find map "\documents\command and conquer generals zero hour data\maps\tansooo\tansooo.map"
CRC Mismatch in Frame 111
Elapsed Time: 00:00 Game Time: 00:03/99:09

It shouldn't get to the mismatch message, but the missing map warning does get printed out.

[Caball009]

Was your custom map folder missing or was it empty? I only checked missing.

[bobtista]

It's empty yeah

[bobtista]

Actually you're right it prints either way, updated the issue description