🐛 apply schema compatibility fixes to generated models - #69
Merged
igotinfected merged 1 commit intoOct 3, 2026
Merged
igotinfected merged 1 commit into
igotinfected merged 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 3, 2026
igotinfected
added this pull request to stack #73
October 3, 2026 22:40
igotinfected
marked this pull request as ready for review
October 3, 2026 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the vendored generator and analyzer together so consumers get the choice and serialization fixes across existing schema versions.
Changes
Enabled scalar default-presence tracking and added SIRI regressions for repeated and optional choices, fixed values, and default assignment. Added a NeTEx regression for edits inside default objects. Object-valued defaults retain their existing serialization behaviour.
XCGA002still requires mandatory choice selection in an initializer. Fixed-value properties remain getter-only, with hidden XML properties and inclusion methods for optional values.Validation
Regenerated every model project, then built and tested the combined worktree. Checked the packed assemblies and bundled analyzer. The vendored packages are
99.0.14-local. The Release build has zero warnings or errors, and all191Transmodel tests pass. A separate packaged consumer accepts valid choices and reportsXCGA001,XCGA002, andCS0200for the corresponding invalid cases.Transmodel stack, bottom to top: #68 → #69 → #70 → #71 → #72. Generator prerequisite: XmlSchemaClassGenerator #1.
This PR was generated with
gpt-6-astrain Codex via T3 Code.