Repository navigation
docs: state each agent rule once and point to it - #1632
Merged
Merged
Conversation
The scaffold's agent docs restated the same rules (typing, the .server.ts boundary, the data rule, the ci gate list, the form-binding rules, the git contract) across AGENTS.md, CONVENTIONS.md, workflow.md, CLAUDE.md, both playbooks and SKILL.md. Every build agent reads all of them, so each copy was paid for on every run. Each rule now lives in one canonical place and the others point to it; the two facts that existed only in the scaffold AGENTS.md (no 'use server' on server-only infra, nothing enforces the typing rule) moved into the skill. Claude-Session: https://claude.ai/code/session_01SZ72LSPAo4NvYvBDSD6RLo
|
Preview for Next: fix the listed keys in the compose file |
A first quality-gate build wrote half the tests once the step only named the gates; the per-feature wording is what asks for them. Claude-Session: https://claude.ai/code/session_01SZ72LSPAo4NvYvBDSD6RLo
Collaborator
Author
|
Quality gate, identical prompt (habit tracker with streaks, weekly overview, dark and light theme) via
Pair 1 on the first commit wrote half the tests (24 vs 47); the verify step had lost "the server, browser, and e2e test layers for the features you built". Restored in the second commit, and pair 2 used it. The always-read agent docs shrink by about 6 KB (about 1.6k tokens). The per-run cost difference is inside run-to-run variance (turn count dominates), so there is no measurable cost change in either direction. |
4 tasks
vivek7405
pushed a commit
that referenced
this pull request
Oct 8, 2026
#1632 reduced the "Type everything" section to a pointer. Typing is the one rule check and tsc cannot enforce, so the concrete forms belong where an agent reads first: the row type, action input and result, routing props, the typed Route union and prop<T>(). The rule itself stays in the skill's Default Workflow step 8.
2 tasks done
vivek7405
added a commit
that referenced
this pull request
Oct 8, 2026
#1632 reduced the "Type everything" section to a pointer. Typing is the one rule check and tsc cannot enforce, so the concrete forms belong where an agent reads first: the row type, action input and result, routing props, the typed Route union and prop<T>(). The rule itself stays in the skill's Default Workflow step 8. Co-authored-by: t <t@t>
3 tasks
vivek7405
pushed a commit
that referenced
this pull request
Oct 8, 2026
Restores every rule #1632 collapsed into a pointer, in AGENTS.md, CONVENTIONS.md, workflow.md, CLAUDE.md, both playbooks and the skill, including the design-token bullet in workflow.md. The saving was about 1,500 tokens per build, small next to a visible drop in how apps look. The partial type-list restore from #1635 is replaced by the original text.
1 task
vivek7405
added a commit
that referenced
this pull request
Oct 8, 2026
Restores every rule #1632 collapsed into a pointer, in AGENTS.md, CONVENTIONS.md, workflow.md, CLAUDE.md, both playbooks and the skill, including the design-token bullet in workflow.md. The saving was about 1,500 tokens per build, small next to a visible drop in how apps look. The partial type-list restore from #1635 is replaced by the original text. Co-authored-by: t <t@t>
2 tasks
vivek7405
added a commit
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every build agent reads the scaffold AGENTS.md (with its playbook), CLAUDE.md, CONVENTIONS.md,
.agents/rules/workflow.mdand the skill's SKILL.md. The same rules were restated across them: the typing rule, the two.server.tskinds, the data rule, thenpm run cigate list, the form-binding rules, the git contract. This keeps each rule in one canonical place and points to it from the others..server.tsboundary: SKILL.md (Default Workflow 8, Core Rules 1 and 2); the scaffold AGENTS.md points there. The two facts only AGENTS.md had (no'use server'on server-only infra, nothing enforces the typing rule) moved into SKILL.md.The skill structure is unchanged (SKILL.md plus the 15 references, none merged, renamed or deleted), and the dark/light theme guidance is untouched.
Quality gate (identical prompt, fresh scaffold from main vs this branch): results posted below.
https://claude.ai/code/session_01SZ72LSPAo4NvYvBDSD6RLo