Repository navigation
Preserve wedding guest sessions across deploys - #48
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The real wedding-demo user test found broken private images in an existing guest session while fresh CI guests passed. Ordinary backend deploys generated a new JWT signing key and replaced JWKS. Two unexpired browser tokens no longer verified against the current public keys; private-media authorization returned HTTP 500.
Changes
--force. Refuse incomplete/malformed/mismatched keys and an implicit seed-key rotation.uploadCodeargument: invitation codes belong to sign-in.Validation
yarn check: 285 tests pass, no type errors. Tests use real RSA signatures with a local mocked CLI; existing sessions remain verifiable across redeployment, malformed/partial/mismatched inputs refuse, secret output is suppressed, and batch initialization/ambiguous outcomes are covered.dea765aad6038400b5d9bdf8fa32f90de97fd554. Main CI / production deployment 38801367700 passed, including real private-Storage upload, Range, seek, original fidelity and denial. The production backend logged “Deployment auth keys preserved.” at 20:24:19Z; the preview also exercised first initialization and a later preserve path.Already-invalid tokens are not repaired by preserving the current key; affected guests may need to re-enter. The fix prevents ordinary future deploys from invalidating working sessions. Mobile performance and starter simplification findings remain separate proposals in the single DAM living plan.
🤖 Claimed by kvz on
studio1/convexsince 2026-10-15 · resume:codex resume 019fa2ee-f994-79d0-9d50-071bf2cb7ad6