Repository navigation
Use published Convex package in wedding demo - #47
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The wedding demo should dogfood what an application developer can actually install. Until now its package imports resolved to this repository's TypeScript source, even after a release.
Changes
@transloadit/convex@0.5.0as an exact private example dependency; remove repository-source path aliases.Validation
yarn check: 273 tests pass, no type errors.yarn example:build: pass; installed package resolves fromexample/node_modules, not repository source.yarn dedupe: no duplicate ranges.d4b59c60ee4762ae34bcfeaef639a4d1546da76f; main run 38797391532 passed the automatic production-demo deployment and real private-Storage upload/playback/original-byte/access-denial acceptance.Merging uses the existing automatic wedding-demo deployment. No API2 production deployment or Storage enrollment change is included.
🤖 Claimed by kvz on
studio1/convexsince 2026-10-15 · resume:codex resume 019fa2ee-f994-79d0-9d50-071bf2cb7ad6