Repository navigation
Update protobuf runtime to v1.33.0 - #19
Merged
Merged
Conversation
Raise the minimum Go version to 1.17 as required by the patched runtime. Preserve generated schemas and add binary encoding controls captured on the previous runtime.
This was referenced Sep 14, 2026
Extracts the section matching the pushed tag's version (Keep a Changelog format) and publishes it as the release body via softprops/action-gh-release. Release-publishing only; does not touch or duplicate gofmt.yml/test.yml.
ci: publish a GitHub Release from CHANGELOG.md on v* tag push
- PR #19 added to the unreleased PR-stack list - 'Security & correctness hardening (non-breaking)' entry: protobuf v1.33.0 (GHSA-8r3f-844c-mc37 / Dependabot alert #10) + go 1.17 toolchain floor
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
google.golang.org/protobuffrom v1.27.1 to v1.33.0, the published fixed version for GHSA-8r3f-844c-mc37 (Dependabot alert #10). Raise the module's Go minimum to 1.17, as required by that runtime.The existing binary message format is covered by fixed vectors captured with v1.27.1 for all four generated schemas and the actual Any transport path. The runtime update preserves those bytes, parsed content, and routing. Generated files and schemas are retained; the generator-version check in #18 remains separate.
Validation:
tss,common, andecdsa/signingsuites pass, including ordinary signing and HD signing.This updates an advisory-affected dependency pin. It does not claim that the affected JSON parser was reachable through tss-lib's binary transport.
Notes
go.modnow declaresgo 1.17(a consequence of the protobuf v1.33.0 requirement). Downstream consumers whose toolchain is older than 1.17 must upgrade before adopting this version; thetss,common, andecdsa/signingsuites are verified on the repo's CI toolchain (1.24.x).tss/protobuf_compatibility_test.go(captured on v1.27.1); they will fail under any future runtime bump that changes the encoding, so no separate old+new CI matrix is needed.google.golang.org/protobufadvisories will require follow-up dependency bumps, as usual..github/workflows/release.ymlfile is not modified by this change. An earlier review misread it as a deletion because this branch was cut from a base that predates its introduction onmaster; the branch is being updated to the current base so the diff is clean.Full repository test and formatting CI runs at head
26537a0follow the push; earlier runs (test, formatting) passed at0eb767d9dbc7101a3fc7c4140b14f1091afa2a06.