feat(signing)!: deliver signature results by pointer - #39
Merged
Merged
Conversation
common.SignatureData is a protobuf message and embeds a mutex, so delivering it by value over the signing end channel made every receiver copy a lock (go vet copylocks). The end channel is now chan<- *common.SignatureData and the party stores its data by pointer, matching upstream BNB fbb0ef7. finalize sends a proto.Clone so the receiver owns a deep copy.
piotr-roslaniec
added a commit
to threshold-network/keep-core
that referenced
this pull request
Oct 2, 2026
Bump the tss-lib pin to 6056170 (threshold-network/tss-lib#39), whose signing end channel now carries *common.SignatureData. Receiving the protobuf message by value copied its embedded mutex; go vet ./pkg/tecdsa/... is now clean.
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking API change for signing callers.
common.SignatureDatais a protobuf message and embeds a mutex. Delivering it by value over the signing end channel makes every receiver copy a lock, sogo vetreports copylocks (keep-core already trips it). This switches to the API upstream BNB adopted infbb0ef7, which this fork had deferred as unneeded API churn. The protobuf runtime upgrade (#19) is what made the by-value form wrong, and #37 already breaks the signing constructor, so making the change before the first tagged release avoids a second breaking release.Changes
signing.NewLocalParty/NewLocalPartyWithKDDtakeend chan<- *common.SignatureData.LocalPartystores its signature data by pointer, matching upstream.finalizesendsproto.Clone(round.data), so the receiver owns a deep copy and shares nothing with the party. Upstream sendsround.dataitself; this is the only difference.historical_signeris unchanged because it builds against the pinned historical tss-lib.Migration
Verification
go build ./...,go vet ./...,go test -run ^$ ./...(every test binary compiles): passgo test -race -shuffle=on ./ecdsa/signing: pass