Skip to content

fix(knowledge): bound permission pagination and member cleanup - #7918

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/atlassian-sync-recovery
Sep 17, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/atlassian-sync-recovery

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Read large Confluence permission collections incrementally, detect repeated pages, and keep verification bounded without publishing partial permissions.
  • Select member cleanup candidates before each bounded update and recheck observations under the sync lease.
  • Show the existing permission warning in source details and align the Confluence troubleshooting guide.

Type of Change

  • Bug fix

Testing

295 unit/component tests and 18 disposable PostgreSQL integration tests passed. Covered large permission collections, malformed pagination, observation races, lease loss, and multi-batch cleanup. Live Confluence tests remain opt-in and were skipped. App type check, full lint, all 46 audits, block registry, and docs manifest checks passed. No schema changes.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 17, 2026 6:36am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the previous permission-warning issue fixed and manually resolved and no new actionable defects identified.

Summary

This PR makes Confluence permission collection fail closed while supporting large paginated datasets, bounds memory and runtime use, and makes member-document cleanup safe across batches and observation races. It also exposes permission-verification warnings consistently in source details and updates troubleshooting documentation.

  • Streams and validates Confluence permission pages with cursor, page, response-size, timeout, and ACL limits.
  • Selects lifecycle candidates in deterministic bounded batches and rechecks eligibility while holding the sync lease.
  • Keeps connector-level permission warnings visible independently of member synchronization errors.
  • Adds unit, component, and PostgreSQL integration coverage for pagination and lifecycle edge cases.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Request Confluence permission page] --> B{Page valid and bounded?}
  B -- No --> H[Fail without publishing permissions]
  B -- Yes --> C{Repeated page or cursor?}
  C -- Yes --> H
  C -- No --> D[Accumulate unique reader principals]
  D --> E{Continuation present?}
  E -- Yes --> A
  E -- No --> F[Publish complete permission set]
  I[Select bounded lifecycle candidates] --> J[Acquire and verify sync lease]
  J --> K[Recheck observations and document state]
  K --> L[Apply tombstone or resurrection update]
  L --> M{More candidates before deadline?}
  M -- Yes --> I
  M -- No --> N[Finish or leave remaining work for next run]
Loading

Reviews (2) · Last reviewed commit: "fix(knowledge): retain permission notice..."

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the codex/atlassian-sync-recovery branch from 67bb92a to 709afcd Compare September 17, 2026 06:34
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit f16ce72 into staging Sep 17, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/atlassian-sync-recovery branch September 17, 2026 18:22

This branch was successfully deployed

1 active deployment
Preview — 709afcdd Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant