Skip to content

Commit 709afcd

Browse files
committed
fix(knowledge): retain permission notices alongside member errors
1 parent 1839da4 commit 709afcd

2 files changed

Lines changed: 20 additions & 1 deletion

File tree

‎apps/sim/app/o/[organizationId]/settings/integrations/sources/[connectorId]/source-detail.test.tsx‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,25 @@ describe('organization source detail navigation', () => {
273273
}
274274
)
275275

276+
it.each(['idle', 'pending', 'running'] as const)(
277+
'preserves a connector permission warning alongside a member error while %s',
278+
async (memberSyncStatus) => {
279+
mocks.detail.mockReturnValue({
280+
data: {
281+
...connector,
282+
accessMode: 'members',
283+
memberSyncStatus,
284+
lastSyncError: SOURCE_PERMISSION_ERROR,
285+
lastMemberSyncError: 'Private member error details',
286+
},
287+
})
288+
await render()
289+
expect(container.textContent).toContain('Permission verification incomplete')
290+
expect(container.textContent).toContain(SOURCE_PERMISSION_ERROR)
291+
expect(container.textContent).not.toContain('Private member error details')
292+
}
293+
)
294+
276295
it.each(['', '?view=settings', '?view=history'])(
277296
'shows integration deactivation independently of source sync state at %s',
278297
async (searchParams) => {

‎apps/sim/app/o/[organizationId]/settings/integrations/sources/[connectorId]/source-detail.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ function SourceDetailContent({
187187
? describeSearchSource(meta, connector.sourceConfig) || meta.name
188188
: 'Connection'
189189
const { effectiveStatus, lastSyncError } = getConnectorSyncState(connector)
190-
const permissionsIncomplete = lastSyncError === SOURCE_PERMISSION_ERROR
190+
const permissionsIncomplete = connector.lastSyncError === SOURCE_PERMISSION_ERROR
191191
const status =
192192
effectiveStatus === 'paused'
193193
? 'Sync paused'

0 commit comments

Comments
 (0)