feat(channels): P2 — clustering & editorial collections - #2151
Merged
Conversation
jung-thomas
added a commit
that referenced
this pull request
Sep 4, 2026
…ollections fix(channels): unbreak unit-tests slug-lookup guard after PR #2151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2 — Clustering & Editorial Collections (external SAP channels integration)
Implements Phase 2 of the external channels integration spec (
docs/superpowers/specs/2026-09-04-external-channels-integration-design.md), adding curator-reviewed editorial collections that group published channels and lead the/channelsdirectory landing.What's included (7 tasks, spec §5.2/§8/§10/§13/§15)
ChannelCollections+ChannelCollectionItemsentities (reuse existingAuthoringStatusenum),@cds.persistence.journal, regenerated csn + migration tables.GET /build/channel-collections, hard-gated onisPublished && authoringStatus === 'REVIEWED', broken-link item filtering (P1 parity).ChannelCollections(draft-enabled) +ChannelCollectionItemsprojections onAdminService.app/admin/channel-collections/Fiori Elements app + shell registration (nav, prefix, manifest regenerated).srv/lib/channels/seed-collections.js+npm run seed-collections; idempotent, preservesREVIEWED, writes drafts asAI_SEEDED; AI SDK lazily imported (off srv-qa boot path)./channelsdirectory; bakedhugo/data/channel_collections.json+ island section, degrades cleanly when empty./channelscollections spec (self-skips withoutSMOKE_BASE_URL).Scope boundary
P3 (
ChannelTopicMap) and P4 (ChannelSubmissions) are explicitly out of this PR.Testing
check-cds-build-stagingandcheck-srv-qa-cp-listgates exit 0.Review notes
Built via subagent-driven development (fresh implementer + spec/quality gate per task, broad final review). Final review caught + fixed a Hugo data-key mismatch (hyphen vs underscore filename) that would have silently hidden all collections — now
channel_collections.jsonmatches.Site.Data.channel_collections.Not deployed — deploy is a separate explicit step.