fix(channels): unbreak unit-tests slug-lookup guard after PR #2151 - #2152
Merged
Conversation
…eak unit-tests guard
draftCollections() already lowercases d.slug at source, so the
SELECT.one.where({ slug: d.slug }) lookup is write-path-canonical.
Add the slug-canonical marker so check-slug-lookups.ts passes (it
was failing the 'unit tests' CI job after PR #2151).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
unit testsCI job (Static build guards →check-slug-lookups.ts) went red on DEV after PR #2151 (channels-p2-collections) merged:Fix
draftCollections()already canonicalizes the slug at source (slug: String(d.slug).toLowerCase()), and both this lookup and the subsequent INSERT reuse that samed.slug. So the value is write-path-canonical — the correct fix is the guard marker, not a redundant.toLowerCase().Added:
// slug-canonical: write-path-canonicalizes — draftCollections() lowercases d.slug at sourceVerification
npx tsx scripts/check-slug-lookups.ts→OK — 113 lookup(s) inspected; 68 marked ..., exit 0.Note: the sibling Deploy Docs failure (missing
channelssidebar entry) was already fixed on DEV in a later commit — no action needed there.