Skip to content

Add const to ServiceBase::get_service_name #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahcorde merged 1 commit into from
Sep 4, 2026
Merged

Add const to ServiceBase::get_service_name #3253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclcpp/include/rclcpp/service.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class ServiceBase
/** \return The name of the service. */
RCLCPP_PUBLIC
const char *
get_service_name();
get_service_name() const;

/// Return the rcl_service_t service handle in a std::shared_ptr.
/**
Expand Down
2 changes: 1 addition & 1 deletion rclcpp/src/rclcpp/service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ ServiceBase::take_type_erased_request(void * request_out, rmw_request_id_t & req
}

const char *
ServiceBase::get_service_name()
ServiceBase::get_service_name() const
{
return rcl_service_get_service_name(this->get_service_handle().get());
}
Expand Down