Repository navigation
Add const to ServiceBase::get_service_name - #3253
Merged
Merged
Conversation
Signed-off-by: pum1k <55055380+pum1k@users.noreply.github.com>
fujitatomoya
approved these changes
Sep 3, 2026
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
lgtm with green CI.
Important
this is ABI breaking change, not backporting.
Collaborator
|
Pulls: #3253
|
ahcorde
approved these changes
Sep 4, 2026
Contributor
Author
|
Would it be safe to create a backport that adds the const version as an overload or is that also forbidden? const char * get_service_name();
const char * get_service_name() const; |
Collaborator
|
we can do that, but i do not think that is necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ServiceBase::get_service_namewas not marked const, but I see no reason for it not to be.(
ClientBase::get_service_nameis already const.)Is this user-facing behavior change?
Yes, it allows calling the function in more contexts.
Did you use Generative AI?
No