Repository navigation
fix(ui): a quoted settings list draws one unbroken line - #1291
Merged
Merged
Conversation
JamieRuderman
added a commit
that referenced
this pull request
Oct 13, 2026
…cation method its own icon (#1290) * feat(notifications): note what mobile push covers and show it with a phone icon * feat(notifications): describe each kind of push, and give email and webhook their own icons * fix(ui): a quoted settings list draws one unbroken line (#1291) * fix(ui): a quoted settings list draws one unbroken line * refactor(ui): Quote spans its list row itself, with the theme's row spacing named * feat(push): account security pushes on by default (#1292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the breaks in the vertical line beside the push category toggles on the Notifications page. The fix is a capability of
Quoterather than a special case in one list. Stacked on #1290.Cause
ListItemSetting'squotedraws the line as theQuotebox's left border, and that box sits inside each list row. The theme's row padding (5px) and margin (1px) sit outside the border, so every row's line stopped short of the next.Change
QuotegainsspanRow: when the quote sits inside a list row, it reaches over that row's own padding and margin (a negative vertical margin, plus the same amount as padding). Stacked quoted rows draw one line. The row's own layout, height, hover and selected backgrounds are unchanged.LIST_ITEM_PADDING_YandLIST_ITEM_MARGIN_Yinstyling/index.ts.theme.ts's list-row style andQuoteboth use it, so they can't drift apart.ListItemSettingrenders<Quote spanRow>forquoterows, which coversPushCategoryListandUpdateSetting.Verification
vitest run src/components: 33 tests pass.Simplify ran on this PR. It moved the fix from a row-padding override in
ListItemSettingplus a newQuotesxprop into thisQuoteprop, with the shared spacing constants.