Repository navigation
feat(push): account security pushes on by default - #1292
Merged
Merged
Conversation
JamieRuderman
force-pushed
the
feat/push-account-default
branch
from
October 12, 2026 23:40
29df09a to
2658f76
Compare
JamieRuderman
added a commit
that referenced
this pull request
Oct 12, 2026
* fix(ui): a quoted settings list draws one unbroken line * refactor(ui): Quote spans its list row itself, with the theme's row spacing named * feat(push): account security pushes on by default (#1292)
JamieRuderman
added a commit
that referenced
this pull request
Oct 13, 2026
…cation method its own icon (#1290) * feat(notifications): note what mobile push covers and show it with a phone icon * feat(notifications): describe each kind of push, and give email and webhook their own icons * fix(ui): a quoted settings list draws one unbroken line (#1291) * fix(ui): a quoted settings list draws one unbroken line * refactor(ui): Quote spans its list row itself, with the theme's row spacing named * feat(push): account security pushes on by default (#1292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app's copy of the push defaults now includes account security, mirroring remoteit/graphql-api#361, so the Notifications page shows Account security on for anyone who hasn't chosen their own categories. Stacked on #1291.
DEFAULT_PUSH_CATEGORIESinfrontend/src/constants.tsgainsaccount. It mirrors the server's list, and both must change together.The PushCategoryList test passes. Skipped simplify, the code review and Codex: a one-line default change.