Repository navigation
feat(notifications): describe each kind of push, and give each notification method its own icon - #1290
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…ebhook their own icons
JamieRuderman
changed the title
* fix(ui): a quoted settings list draws one unbroken line * refactor(ui): Quote spans its list row itself, with the theme's row spacing named * feat(push): account security pushes on by default (#1292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explains what each kind of mobile push covers, and gives each notification method its own icon.
Push kinds
Each switch under Mobile push now has a one-line description, in Settings → Notifications and in a device's Device Notifications. The text matches what graphql-api sends for each kind:
All five are translated in ja, de and es, using the catalogs' existing terms (2段階認証, Zwei-Faktor, dos factores; 譲渡, übertragen, transferir).
Icons
mobile-vibrate/mobile-vibrate-slash.envelope/envelope-slash.webhook/webhook-slash.Font Awesome has no slashed envelope or webhook.
assets/slashedIcons.tsdefines both as regular-weight icons: the stock glyph with Font Awesome's own slash cut through it, at the same gap the built-in slash icons use. They're registered inIcon.tsxbeside the Pro sets, so<Icon name="envelope-slash" />works like any other name.ListItemSwitchgains optionalicon/offIconprops, which default to the bell so other callers are unchanged.Checks
npm run typecheck: passes.npm run i18n:check: passes.ListItemSwitchandNotificationSettingstests pass.I skipped simplify, code review and Codex because this is copy, icons and two optional props. ESLint can't run in this repo: the frontend config extends
react-app, which isn't installed. That isn't new with this change.