Skip to content

Add Proof Items for the Merge-Bot rules Input and merge-app Job - #2665

Merged
ptr727 merged 2 commits into
developfrom
feature/auto-2412
Oct 9, 2026
Merged

ptr727 merged 2 commits into
developfrom
feature/auto-2412

Conversation

@ptr727

@ptr727 ptr727 commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Filed along the way as #2664: the Stage 1 items the live evidence already closes, which this change leaves alone.

Closes on promotion: #2412

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated rollout notes with completed end-to-end proofs from PhotoCleaner and homeassistant-purpleair.
    • Clarified which adopter verifies each of four behaviors and linked to the homeassistant-purpleair proof run.

ptr727 and others added 2 commits October 9, 2026 09:31
The rules input and the merge-app job were owed proofs with no tracker
item. Both proofs now sit under Stage 1, ticked with the
homeassistant-purpleair run that showed them, and the pointers that
named the issue as their tracker now name those items instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The merge step enables auto-merge rather than merging inside the run,
so the proof items now say that and name the merge separately. The
pointer prose also says which repository each proof item names rather
than which one owes it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 9, 2026 16:38
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2e2a3994-9af3-4ac1-b7f8-0e952f69eac4

📥 Commits

Reviewing files that changed from the base of the PR and between 7c44119 and 0ff42fb.


📒 Files selected for processing (2)
  • TODO.md
  • docs/reusable-workflows.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The adoption notes now record downstream proof for four reusable-workflow behaviors. They cite PhotoCleaner for cross-repository resolution and Dependabot pin bumps, and homeassistant-purpleair for the rules input and merge-app job. The obsolete issue reference was removed.

Changes

Adoption proof documentation

Layer / File(s) Summary
Record downstream workflow proofs
TODO.md, docs/reusable-workflows.md
The notes identify proof for all four behaviors. They record the homeassistant-purpleair run and pull request, and remove the obsolete issue reference.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes


Merge Risk: ⚪ Minimal · up to 0ff42

The documentation distinguishes the run enabling auto-merge from the later PR merge. No merge-blocking issue was established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the two main documentation changes: adding proof items for the merge-bot rules input and merge-app job.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The only noted issue is a non-blocking documentation nit.

0 open findings

What changed in this PR

Adds live proof records for the merge-bot rules input and merge-app job, with related documentation updates.

Changes:

  • Adds two checked Stage 1 proof items.
  • Updates TODO.md and pilot documentation.
  • Removes obsolete issue references.
File Summary
TODO.md Updates merge-bot proof tracking.
docs/​reusable-workflows.md Adds proof items and run reference. Nit (1 vote): use clickable reference links for cited pull requests.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.34%. Comparing base (7c44119) to head (0ff42fb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2665   +/-   ##
========================================
  Coverage    59.34%   59.34%           
========================================
  Files           16       16           
  Lines         8282     8282           
========================================
  Hits          4915     4915           
  Misses        3367     3367           
Flag Coverage Δ
python-3.13 59.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

Answering the one body-only note in Copilot's review round on 0ff42fbd, which holds no thread (0 open findings, 1 nit in the file table).

docs/reusable-workflows.md: Nit (1 vote): use clickable reference links for cited pull requests.

No change needed. The new items cite pull requests the way the rest of the Rollout tracker already does. grep -c 'ptr727/[A-Za-z-]*#[0-9]' docs/reusable-workflows.md counts 35 lines citing a cross-repository pull request as bare ptr727/<repo>#<n>, for example ptr727/PhotoCleaner#53, ptr727/HomeAutomation-Config#58, and ptr727/NxWitness#592 in the same Stage 1 list. Linking only the two new citations would make this list inconsistent with itself. The run each proof is ticked with is already a reference-style link, [run-purpleair-417], matching the Stage 0 proof items' [run-770] and [run-771].

@ptr727

ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ptr727
ptr727 merged commit 2cb7380 into develop Oct 9, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/auto-2412 branch October 9, 2026 16:52
ptr727 added a commit that referenced this pull request Oct 9, 2026
Promotes the one change develop holds over main:
`docs/reusable-workflows.md` gains the merge-bot `Proof:` items for the
`rules` input and the `merge-app` job, and neither it nor `TODO.md`
points at #2412 any more (#2665).

Fixes #2412

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants