Skip to content

Promote the Merge-Bot rules and merge-app Proof Items to Main - #2666

Merged
ptr727 merged 1 commit into
mainfrom
develop
Oct 9, 2026
Merged

ptr727 merged 1 commit into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Promotes the one change develop holds over main: docs/reusable-workflows.md gains the merge-bot Proof: items for the rules input and the merge-app job, and neither it nor TODO.md points at #2412 any more (#2665).

Fixes #2412

🤖 Generated with Claude Code

## Summary

- Adds the two merge-bot `Proof:` items #2412 asks for under "Stage 1:
Merge-Bot Adoption" in `docs/reusable-workflows.md`, one for the `rules`
input end to end and one for the `merge-app` job.
- Both name homeassistant-purpleair, whose `check-ha-version.yml`
tracker opens App pull requests from `ha-version-bump/matrix` that only
its stub's `rules` entry matches. Both are ticked with the run that
produced the proof, the `Merge App pull request job` run for
ptr727/homeassistant-purpleair#417, the first tracker pull request after
the stub landed in ptr727/homeassistant-purpleair#371.
- Updates the "What a Pilot Proves" sentence and the matching `TODO.md`
detail so neither points at #2412 any more, and drops the now unused
`issue-2412` link definitions.

Filed along the way as #2664: the Stage 1 items the live evidence
already closes, which this change leaves alone.

Closes on promotion: #2412

🤖 Generated with [Claude Code](https://claude.com/claude-code)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Updated rollout notes with completed end-to-end proofs from
PhotoCleaner and homeassistant-purpleair.
* Clarified which adopter verifies each of four behaviors and linked to
the homeassistant-purpleair proof run.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 9, 2026 16:53
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d9cca040-2226-4f64-86b1-17fb3d003093

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only a minor wording nit remains, with no blocking issues.

0 open findings

What changed in this PR

Promotes merge-bot proof documentation and removes obsolete issue references.

Changes:

  • Adds verified rules and merge-app proof evidence.
  • Updates TODO.md to track all four proofs.
  • Removes references to issue #2412.

Review note: one minor wording nit was identified in docs/reusable-workflows.md.

File Summary
TODO.md Updates merge-bot proof tracking.
docs/​reusable-workflows.md Records completed proof evidence and workflow-run reference.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.34%. Comparing base (7c44119) to head (2cb7380).
⚠️ Report is 352 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2666   +/-   ##
=======================================
  Coverage   59.34%   59.34%           
=======================================
  Files          16       16           
  Lines        8282     8282           
=======================================
  Hits         4915     4915           
  Misses       3367     3367           
Flag Coverage Δ
python-3.13 59.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

Answering the one body-only note in Copilot's review round on 2cb7380a, which holds no thread (0 open findings, 1 note).

Review note: one minor wording nit was identified in docs/reusable-workflows.md.

No change needed. The round names no line, sentence, or wording for the nit, so there is nothing in it to act on or disprove. The same content was reviewed on its feature pull request, #2665, where Copilot's one named nit on this file (use reference links for cited pull requests) is answered with evidence in this comment. This promotion carries that one change and nothing else, so its diff is the reviewed one.

@ptr727
ptr727 merged commit 84f0699 into main Oct 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Proof Items for the Merge-Bot rules Input and merge-app Job

2 participants