Conversation
…/TiDB/PD dashboards
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe Grafana Overview, PD, and TiDB dashboard documentation now uses English metric and panel names. Japanese descriptions and normal-range values remain unchanged. ChangesGrafana metric translations
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to This documentation change restores English Grafana labels while retaining Japanese descriptions. Two Overview panel labels remain inconsistent with their dashboard titles, which can mislead users locating those panels but has bounded documentation impact. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 09b21e65-f873-4c40-b6bf-e9bf6ac0f2ab
📒 Files selected for processing (3)
grafana-overview-dashboard.mdgrafana-pd-dashboard.mdgrafana-tidb-dashboard.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
ti-chi-bot
Bot
added
size/XXL
…ification/Size available ratio
…TiDB dashboard descriptions
…B dashboard descriptions
…g-peers description
…on rate terminology
… duration per Chinese source, not rate
…ack, not the OS itself
…nese source convention
… in Schema Lease Error OPM
qiancai
added
translation/no-need
[LGTM Timeline notifier]Timeline:
|
# Conflicts: # grafana-overview-dashboard.md # grafana-tidb-dashboard.md
…oring doc ticdc/monitor-ticdc.md documents the literal panel/metric names shown on the actual TiCDC Grafana dashboards (both the new-architecture and classic-architecture monitoring boards). Nearly every bullet label across all 9 sections had been translated into Japanese, breaking the reader's ability to match a label against what they see in Grafana -- the same defect class documented for the grafana-*-dashboard.md files in PR pingcap#23763 (see memory ja-grafana-panel-names-english). Restored all metric/panel labels to literal English (matching the live Grafana panel/section names) while keeping the Japanese description text after each label unchanged. Also fixed 2 section headings and the panel-name references in prose that had drifted from their own anchor's English name (e.g. 概要/サーバー panel-name mentions not matching the Summary/Server heading english form). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…peer mistranslation - follower-read.md: restored a Grafana breadcrumb link (TiDB > KV Request > Read Req Traffic panel) to literal English, matching the panel-name defect class from PR pingcap#23763. - grafana-performance-overview-dashboard.md: restored all panel/metric labels across every section (Performance Overview, TiFlash, CDC) to literal English while keeping descriptions in Japanese; also fixed several scrambled/garbled sentences found in the same pass (QPS, avg by type, kv request by type bullets) and a duplicated Raft/Raft typo. - grafana-resource-control-dashboard.md: same treatment across all 3 metric sections. - glossary.md: fixed a same-file self-contradiction where the Region/Peer section heading and its inbound link used 仲間 (an informal, wrong register for 'peer') while the section's own body text already correctly used the established term ピア for the identical concept. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 participants
What is changed, added or deleted? (Required)
Restores literal English Grafana panel/metric names in three Japanese monitoring docs. These panel names (e.g. "Services Up", "PD role", "Duration", "CPS By Instance") are literal strings shown in the actual Grafana dashboard UI and must stay in English, matching the convention already established for
tidb-cloud/built-in-monitoring.md(#23751). Descriptions after each panel name remain translated.grafana-overview-dashboard.md: 49 panel-name table cells restored to Englishgrafana-tidb-dashboard.md: 126 panel-name bullet leads restored to Englishgrafana-pd-dashboard.md: 76 panel-name bullet leads restored to EnglishWhich TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit