Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughUpdated Japanese DM validation terminology to quoted English status terms and added the TiCDC version ChangesDM documentation terminology
Version metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change standardizes quoted English DM status terms and adds TiCDC version 8.5.8 metadata. No current merge-readiness risk has been identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…758-merge # Conflicts: # dm/dm-query-status.md
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Found while investigating a similar literal-value defect on PR #23635. In
dm/dm-query-status.mdanddm/dm-continuous-data-validation.md, several quoted literal status/enum values that DM'squery-status/validationcommands actually return (or that a user matches against verbatim) had been translated into Japanese and re-quoted with full-width corner brackets (「」) instead of being kept as the literal English string in double quotes (""), matching the EN source:dm/dm-query-status.md:"stage"/"subTaskStatus"/"sources"/"unresolvedDDLLockID"(JSON field names) and"Check"/"Dump"/"Load"/"Sync"(DM processing unit names) — mistranslated as「stage」-style corner-bracketed Japanese; also"synced"(subtask status value) mistranslated as「同期済み」.dm/dm-continuous-data-validation.md:"ignored","resolved", and"expired"(validation error-row/data status values) mistranslated as「無視」,「解決済み」,「期限切れ」.All fixes verified against the English source on
release-8.5, and use straight double quotes ("") matching EN, not Japanese corner brackets.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit