Skip to content

i18n(ja): restore literal quoted status/enum values in DM docs - #23758

Merged
qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-quoted-literal-status-values-japanese
Sep 10, 2026
Merged

qiancai merged 3 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-quoted-literal-status-values-japanese

Conversation

@yahonda

@yahonda yahonda commented Sep 7, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Found while investigating a similar literal-value defect on PR #23635. In dm/dm-query-status.md and dm/dm-continuous-data-validation.md, several quoted literal status/enum values that DM's query-status/validation commands actually return (or that a user matches against verbatim) had been translated into Japanese and re-quoted with full-width corner brackets (「」) instead of being kept as the literal English string in double quotes (""), matching the EN source:

  • dm/dm-query-status.md: "stage"/"subTaskStatus"/"sources"/"unresolvedDDLLockID" (JSON field names) and "Check"/"Dump"/"Load"/"Sync" (DM processing unit names) — mistranslated as 「stage」-style corner-bracketed Japanese; also "synced" (subtask status value) mistranslated as 「同期済み」.
  • dm/dm-continuous-data-validation.md: "ignored", "resolved", and "expired" (validation error-row/data status values) mistranslated as 「無視」, 「解決済み」, 「期限切れ」.

All fixes verified against the English source on release-8.5, and use straight double quotes ("") matching EN, not Japanese corner brackets.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated Japanese documentation terminology to use consistent English quoted labels: “ignored,” “resolved,” and “expired.”
    • Added the TiCDC version 8.5.8 to the documented version information.

@ti-chi-bot

ti-chi-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2026
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3663bd3c-e466-4a98-92eb-7a7e10e475bd

📥 Commits

Reviewing files that changed from the base of the PR and between 20cbc27 and 9e1f49b.

📒 Files selected for processing (1)
  • variables.json

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Updated Japanese DM validation terminology to quoted English status terms and added the TiCDC version 8.5.8 to the shared version metadata.

Changes

DM documentation terminology

Layer / File(s) Summary
Status terminology normalization
dm/dm-continuous-data-validation.md
The documentation now uses "ignored", "resolved", and "expired" for the related validation states.

Version metadata

Layer / File(s) Summary
TiCDC version metadata
variables.json
Added the "ticdc-version": "8.5.8" property.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9e1f4

This change standardizes quoted English DM status terms and adds TiCDC version 8.5.8 metadata. No current merge-readiness risk has been identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the required change, affected version, reference PR, AI involvement, and change classifications. The optional first-time contributor section is not required for all contributors…
Title check ✅ Passed The title clearly and concisely describes the primary change: restoring literal quoted status and enum values in the Japanese DM documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…758-merge

# Conflicts:
#	dm/dm-query-status.md
@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-10 03:09:14.97481315 +0000 UTC m=+1939990.145907302: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit d13d772 into pingcap:i18n-ja-release-8.5 Sep 10, 2026
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants