fix(files): release locks after failed stream uploads#62427
Draft
joshtrichards wants to merge 2 commits into
Draft
fix(files): release locks after failed stream uploads#62427joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Assisted-by: Copilot:GPT-5.6 Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
2. developing
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stream-based
View::file_put_contents()uploads can retain an exclusive lock if the storage backend throws after lock escalation.This PR ensures cleanup releases the currently held lock on all failure path and adds regression coverage for a destination-storage
fopen()exception. Also includes minor refactoring of the function to flatten it by using early guards to improve readability.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)