fix(files): release locks when basic operations fail#62428
Draft
joshtrichards wants to merge 2 commits into
Draft
fix(files): release locks when basic operations fail#62428joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Ensure View::basicOperation() releases the currently held lock when pre/post hooks, path resolution, storage calls, or cache updates throw. Keep successful fopen() lock ownership with the wrapped stream callback. Modernize: Move guards to the top to flatten logic/improve readability. Signed-off-by: Josh <josh.t.richards@gmail.com>
Assisted-by: Copilot:GPT-5.6 Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure
View::basicOperation()always releases the currently held lock when an exception occurs after locking, including failures from filesystem hooks, path resolution, storage operations, cache updates, and post-hooks.Successful
fopen()calls continue to transfer lock cleanup to the wrapped stream callback.Adds regression coverage for a throwing pre-write hook to verify no lock remains afterward.
Use the same pattern as PR #62427, which was/is for streamed
View::file_put_contents().TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)