Skip to content

fw: recompute virtual FIB depth after pruning #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harsh23Kashyap wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fw: recompute virtual FIB depth after pruning #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fw/table/fib-strategy-hashtable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ func (f *FibStrategyHashTable) pruneTables(entry *baseFibStrategyEntry) {
delete(f.virtTable, virtNameHash)
} else {
// Update with length of next longest real prefix associated
// with this virtual prefix
// with this virtual prefix.
virtEntry.md = 0
for _, l := range f.virtTableNames[virtNameHash] {
virtEntry.md = max(virtEntry.md, l)
}
Expand Down
15 changes: 15 additions & 0 deletions fw/table/fib-strategy-hashtable_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,3 +489,18 @@ func TestFIB_HT_RealAndVirtualNodes(t *testing.T) {
testFIB_HT_Details(t, uint16(i))
}
}

func TestPruneRecomputesVirtualDepth_HT(t *testing.T) {
newFibStrategyTableHashTable(2)

shortName, _ := enc.NameFromStr("/a/b/c")
longName, _ := enc.NameFromStr("/a/b/c/d")
FibStrategyTable.InsertNextHopEnc(shortName, 1, 1)
FibStrategyTable.InsertNextHopEnc(longName, 2, 1)

FibStrategyTable.RemoveNextHopEnc(longName, 2)

table := FibStrategyTable.(*FibStrategyHashTable)
virtualName, _ := enc.NameFromStr("/a/b")
assert.Equal(t, len(shortName), table.virtTable[virtualName.Hash()].md)
}
Loading