fw: recompute virtual FIB depth after pruning - #208
Open
Harsh23Kashyap wants to merge 1 commit into
Open
Harsh23Kashyap wants to merge 1 commit into
Harsh23Kashyap wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #207
pruneTableswas recomputing a virtual node's maximum depth from the old maximum, which meant the value could never decrease after the longest real name was removed. Resetting it before scanning the remaining names keeps the virtual-node metadata in sync.The regression test inserts depth-3 and depth-4 names under the same virtual prefix, removes the depth-4 name, and checks that the stored maximum becomes 3.
Tests:
go test ./fw/table -run TestPruneRecomputesVirtualDepth_HT -count=1(twice)go test ./fw/table -count=1go test ./... -count=1