Skip to content

docs(skills): keep type units and meaningful orders when ordering by reach - #189

Merged
mpyw merged 1 commit into
mainfrom
docs/order-by-reach-units
Oct 8, 2026
Merged

mpyw merged 1 commit into
mainfrom
docs/order-by-reach-units

Conversation

@mpyw

@mpyw mpyw commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Summary

Applying "Order by reach" to 14 repositories showed gaps in the rule. This PR fixes them in declscope-authoring.

Gap seen Example Change
Ordering a run of types separated a type from its constructor gormreuse: ignoreEntry landed between IgnoreMap and BuildIgnoreMap A type and the constructors and methods right after it are one unit, moved as a whole at the type's reach
A sequence ran across a section comment suve: // Param Types Section comments bound a sequence. Order inside each section
Ordering constants broke a flow order, and comments that introduced a group ended up after it paypay bridge: step names, page labels A new "Keep an order the reader relies on" paragraph: steps in run order, values that follow an outside order, introducing comments

declscope does not check any of this. It is guidance only.

Verification

  • go test . passes. The skills are embedded.

🤖 Generated with Claude Code

…reach

Applying the order across fourteen repositories showed two gaps. Ordering
a run of types could separate a type from its constructor, and ordering
constants could break an order the reader relied on, such as steps in the
order they run. A type now moves with its constructors and methods as one
unit, section comments bound a sequence, and an order the reader relies
on is kept like an observable one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mpyw
mpyw merged commit c04c601 into main Oct 8, 2026
8 checks passed
@mpyw
mpyw deleted the docs/order-by-reach-units branch October 8, 2026 02:03
@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (98df2dc) to head (bfe15bc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          50       50           
  Lines        4214     4214           
=======================================
  Hits         4173     4173           
  Misses         41       41           
Flag Coverage Δ
unittests 99.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant