Skip to content

refactor: order declarations by reach as declscope 0.20.4 refines it - #190

Merged
mpyw merged 1 commit into
mainfrom
refactor/order-type-units
Oct 8, 2026
Merged

mpyw merged 1 commit into
mainfrom
refactor/order-type-units

Conversation

@mpyw

@mpyw mpyw commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Summary

Under the type-unit rule from #189, boolSetting and its UnmarshalYAML method in internal/config/config.go are one unit. So the exported File type now comes before that unit. This PR only moves File. No behavior changes.

Verification

  • mise x -- ./test_all.sh passes. The spec stage was skipped locally because fslc was not on PATH.
  • The throwaway ordering checker, updated for type units and section comments, reports nothing.

🤖 Generated with Claude Code

boolSetting and its UnmarshalYAML method are one type unit now, so the
exported File type goes before it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (7593f14) to head (c4972f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          50       50           
  Lines        4214     4214           
=======================================
  Hits         4173     4173           
  Misses         41       41           
Flag Coverage Δ
unittests 99.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpyw
mpyw merged commit e7084e7 into main Oct 8, 2026
10 checks passed
@mpyw
mpyw deleted the refactor/order-type-units branch October 8, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant