Skip to content

fix: make persistent_local_browser work on Windows #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahulrao85 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

fix: make persistent_local_browser work on Windows #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/webwright/tools/persistent_local_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ def _cmd_create(args: argparse.Namespace) -> int:
}
if os.name == "posix":
popen_kwargs["start_new_session"] = True
else:
popen_kwargs["creationflags"] = subprocess.CREATE_NEW_PROCESS_GROUP

proc = subprocess.Popen(chromium_args, **popen_kwargs) # noqa: S603
try:
Expand Down Expand Up @@ -183,6 +185,16 @@ def _cmd_info(args: argparse.Namespace) -> int:
def _terminate_pid(pid: int, kill_timeout: float) -> str:
if pid <= 0 or not _pid_alive(pid):
return "not_running"
if os.name == "nt":
try:
subprocess.run(
["taskkill", "/F", "/T", "/PID", str(pid)],
capture_output=True,
timeout=30,
)
except subprocess.TimeoutExpired:
pass
return "terminated"
try:
os.kill(pid, signal.SIGTERM)
except ProcessLookupError:
Expand Down