fix: make persistent_local_browser work on Windows#60
Open
rahulrao85 wants to merge 1 commit into
Open
Conversation
Two Windows incompatibilities fixed: 1. Process detach: use subprocess.CREATE_NEW_PROCESS_GROUP on Windows instead of start_new_session (POSIX-only) 2. Process termination: use taskkill /F /T /PID on Windows instead of os.kill with SIGTERM/SIGKILL (Unix-only) Fixes: microsoft#58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\persistent_local_browser.py\ uses POSIX-only APIs (\signal.SIGTERM, \start_new_session) which crash on Windows. This fix adds Windows code paths using \subprocess.CREATE_NEW_PROCESS_GROUP\ for process detachment and \ askkill\ for process termination.
Changes
Fixes: #58