Add mapbox feedback list/get - #49
Open
mattpodwysocki wants to merge 1 commit into
Open
mattpodwysocki wants to merge 1 commit into
mattpodwysocki wants to merge 1 commit into
Conversation
Fifth API this session with no prior CLI coverage — completes the naming
doc's V1 scope (directions, isochrone, map matching, matrix, feedback).
Hand-authored into custom-openapi/ since openapi-specs has no spec for this
API either.
feedback create, the write side, is declared in the spec but never reaches
the command surface: confirmed directly against production that a
POST /oauth/register requesting user-feedback:write silently drops it from
the granted scope, the same unregistrable shape UNSUPPORTED_OPERATIONS
already documents for accounts create-token/update-token/delete-token and
styles download-style-zip. No profile path parameter here, so no new
ARG_NAME_OVERRIDES row — this service was never at risk of that collision.
Named the disabled operation createFeedbackItem rather than the shorter
create: the withheld-operation guard in generate_skills.rs checks the bare
command word against every generated file's text, and a bare "create"
collides with the exposed, unrelated `styles create`. Since the operation
is never reachable either way, the internal name doesn't affect anything
user-facing.
Also fixes a --help truncation on all six *_before/*_after time-window
parameters ("ISO 8601." as a leading sentence, same class of bug fixed in
directions.yaml and matrix.yaml earlier) by moving the format note to the
end of each description.
Updated docs/commands.md's own stale operation/group counts while here —
37 operations across 13 groups, not the 33/10 it still said (already
stale by 2 before this branch, from drift this change didn't cause but
was already touching the same sentence).
Smoke-tested against production: list with comma-separated --status/
--category filters, pagination cursor, and get by id, all verified to
return the documented shape. Confirmed create is absent from --help and
errors as an unrecognized subcommand rather than reaching the API.
488 tests, fmt and clippy clean.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same stacking situation as the rest of this stack. Once #43/#44/#45/#48
merge in order, this should be retargeted to
main(gh pr edit --base main). Everything below is scoped to what this PR actually adds on top of#48.
What
mapbox feedback list/get— completes the naming doc's V1 scope(directions, isochrone, map matching, matrix, feedback). Hand-authored into
custom-openapi/since openapi-specs has no spec for this API either.Feedback submitted against Mapbox API responses — filterable by id,
status, category, a free-text search phrase, trace id, or a time window;
sortable; paginated.
feedback createis declared in the spec but never reaches the commandsurface. Confirmed directly against production: a
POST /oauth/registerrequesting
user-feedback:writesilently drops it from the granted scope —the same unregistrable shape
UNSUPPORTED_OPERATIONSalready documents foraccounts create-token/update-token/delete-tokenandstyles download-style-zip. Nomapbox auth logintoken can ever carry it.No
profilepath parameter here, so no newARG_NAME_OVERRIDESrow — thisservice was never at risk of the collision the other four hit.
Two things worth a reviewer's eye
createFeedbackItemrather than the shorter
create: the withheld-operation guard ingenerate_skills.rschecks the bare command word against everygenerated file's text, and a bare
createcollides with the exposed,unrelated
styles create. Caught by that guard failing, not byinspection — worth checking I reasoned about it right.
docs/commands.md's stale operation/group counts. I updated "33 APIoperations across 10 command groups" to the actual 37/13 while I was
already touching that sentence — turned out the 33/10 was stale by 2
even before this branch (verified against
main), from drift this PRdidn't cause. Flagging in case that pre-existing gap is worth its own
look independent of this PR.
Verification
Smoke-tested against production:
listwith comma-separated--status/--categoryfilters and the pagination cursor, andgetby id,both verified to return the documented shape. Confirmed
createis absentfrom
--helpand errors as an unrecognized subcommand rather than reachingthe API.
488 tests,
cargo fmt --checkandcargo clippy --all-targets -- -D warningsboth clean.🤖 Generated with Claude Code