Add mapbox places get/batch - #53
Open
mattpodwysocki wants to merge 1 commit into
Open
mattpodwysocki wants to merge 1 commit into
mattpodwysocki wants to merge 1 commit into
Conversation
Eighth and final API from the original candidate list — completes it.
Hand-authored into custom-openapi/ since openapi-specs has no spec for
this API either.
Full detail for a place — hours, phone, website, photos, address,
coordinates, activity data — by the mapbox_id a Search Box API result
already returned. This API has no search/suggest of its own: get resolves
one id, batch resolves up to 100 in one call via --data '{"ids": [...]}',
the same shape styles create already uses for a body with no sensible
per-field flag.
No profile path parameter, and no listing/detail auto-link risk either:
batch is POST so it's never a candidate for the GET-only linker this
session's ev-charge-finder work just fixed a bug in.
Smoke-tested against production end to end: used search forward to find
two real places (Ferry Building, Golden Gate Bridge), fetched one by id
with get, then fetched both at once with batch.
Also discovered while testing: this environment's token now has real
Search Box API access, which docs/commands.md's search section previously
said it lacked (true when that was written, not true now). Updated the
page's own accounting of what's live-verified vs. not to say so, without
re-capturing search's four Outputs sections in this same change — flagged
as a worthwhile follow-up, not done here.
489 tests, fmt and clippy clean.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same stacking situation as the rest of this stack. Once
#43/#44/#45/#48/#49/#52 merge in order, this should be retargeted to
`main` (`gh pr edit --base main`).
What
`mapbox places get`/`batch` — the eighth and final API from the original
candidate list. Hand-authored into `custom-openapi/` since openapi-specs
has no spec for this API either.
Full detail for a place — hours, phone, website, photos, address,
coordinates, activity data — by the `mapbox_id` a Search Box API result
already returned. This API has no search/suggest of its own:
the same shape `styles create` already uses for a body with no sensible
per-field flag.
No `profile` path parameter, and no listing/detail auto-link risk either
— `batch` is POST, so it's never a candidate for the GET-only linker
#52 just fixed a real bug in.
Verification
Smoke-tested against production end to end: used `search forward` to
find two real places (Ferry Building, Golden Gate Bridge), fetched one by
id with `get`, then fetched both at once with `batch`.
Also discovered while testing, and worth a reviewer's attention: this
environment's token now has real Search Box API access, which
`docs/commands.md`'s Search section previously said it lacked (true when
that was written, not true any more). Updated the page's own accounting of
what's live-verified vs. not to reflect this, without re-capturing
`search`'s four Outputs sections in this same change — that's a
different command group's page to touch, flagged as a worthwhile
follow-up rather than folded in here.
489 tests, `cargo fmt --check` and `cargo clippy --all-targets -- -D
warnings` both clean.
🤖 Generated with Claude Code