[i2c, dv] I2C V1 sign-off - #616
Merged
Merged
Conversation
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
from
June 17, 2026 16:11
2090013 to
0541ff3
Compare
KinzaQamar
requested review from
elliotb-lowrisc,
marnovandermaas and
martin-velay
June 17, 2026 16:11
Closed
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
from
June 18, 2026 10:46
0541ff3 to
eddb068
Compare
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Some initial nits from my end.
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
8 times, most recently
from
June 19, 2026 11:16
ba9e25e to
8130f70
Compare
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
4 times, most recently
from
June 19, 2026 11:49
b0b3b04 to
7796102
Compare
martin-velay
approved these changes
Jun 19, 2026
martin-velay
left a comment
martin-velay
left a comment
Contributor
There was a problem hiding this comment.
This PR LGTM, there are only 2 points I defer to Marno to decide on. Thanks Kinza!
marnovandermaas
previously requested changes
Jun 20, 2026
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Let's wait until I2C D1 is in before merging this.
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
Contributor
There was a problem hiding this comment.
Some minor comments
KinzaQamar
force-pushed
the
i2c_v1_signoff
branch
2 times, most recently
from
June 23, 2026 11:04
ab3a1e2 to
fc0e080
Compare
marnovandermaas
approved these changes
Sep 29, 2026
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org> Co-authored-by: Christian Tchilikov <christian.tchilikov@semify-eda.com>
tchilikov-semify
force-pushed
the
i2c_v1_signoff
branch
from
September 30, 2026 08:15
fc0e080 to
979604d
Compare
Collaborator
|
Thanks for the work on this @KinzaQamar. I've done a rebase on this PR to merge it with the I2C D1 signoff. |
tchilikov-semify
self-requested a review
September 30, 2026 09:28
tchilikov-semify
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.