editor: EditorTemplate request carries chart values#655
Merged
Conversation
Change EditorTemplateRequest to carry the editor chart Values (fetched by the caller) instead of a ChartRef. getChart can exceed the aggregated apiserver request budget, so kube-ui-server only does the fast in-cluster reconstruction from these values; the caller pulls the chart. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #654. Change
EditorTemplateRequestto carry the editor chartValues(fetched by the caller) instead of aChartRef.Why
getChart(pulling the editor chart) can exceed the aggregated apiserver request budget. So kube-ui-server only does the fast in-cluster reconstruction (editor.EditorChartValueManifest) from the supplied values; the caller (b3) pulls the chart and creates the AppRelease.Related