Skip to content

chore: fix build-release failing under newer Swift toolchain #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
udondan wants to merge 1 commit into from
Closed

chore: fix build-release failing under newer Swift toolchain #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ARCHIVE=$(EXECUTABLE).tar.gz
.PHONY: clean build-release package

build-release:
swift build --configuration release -Xswiftc -warnings-as-errors --arch arm64 --arch x86_64
swift build --configuration release --arch arm64 --arch x86_64

package: build-release
$(RELEASE_BUILD)/$(EXECUTABLE) --generate-completion-script zsh > _reminders
Expand Down
4 changes: 2 additions & 2 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,20 @@ let package = Package(
.executable(name: "reminders", targets: ["reminders"]),
],
dependencies: [
.package(url: "https://github.com/apple/swift-argument-parser", .upToNextMinor(from: "1.3.1")),
.package(url: "https://github.com/apple/swift-argument-parser", .upToNextMajor(from: "1.3.1")),
],
targets: [
.executableTarget(
name: "reminders",
dependencies: ["RemindersLibrary"]
dependencies: ["RemindersLibrary"],
swiftSettings: [.unsafeFlags(["-warnings-as-errors"])]
),
.target(
name: "RemindersLibrary",
dependencies: [
.product(name: "ArgumentParser", package: "swift-argument-parser"),
]
],
swiftSettings: [.unsafeFlags(["-warnings-as-errors"])]
),
.testTarget(
name: "RemindersTests",
Expand Down
2 changes: 1 addition & 1 deletion Sources/RemindersLibrary/CLI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ private struct Delete: ParsableCommand {
}
}

func listNameCompletion(_ arguments: [String]) -> [String] {
func listNameCompletion(_ arguments: [String], _ position: Int, _ prefix: String) -> [String] {
// NOTE: A list name with ':' was separated in zsh completion, there might be more of these or
// this might break other shells
return reminders.getListNames().map { $0.replacingOccurrences(of: ":", with: "\\:") }
Expand Down