Conversation
-Xswiftc -warnings-as-errors was applied to the whole build graph, so any warning surfacing in swift-argument-parser under a newer Swift compiler broke the build. Scope the flag to our own targets via Package.swift swiftSettings instead, bump swift-argument-parser past 1.3.x to pick up its Sendable-conformance fixes, and migrate off its now-deprecated single-argument completion closure API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make build-releasefailed under a newer Swift toolchain (Swift 6.3) because-Xswiftc -warnings-as-errorsapplied to the entire build graph, turning warnings inside theswift-argument-parserdependency (Sendable-conformance notes) into hard build errors.swift-argument-parserfrom a1.3.x-only range to allow up to the next major (resolves to 1.8.2), which fixes those Sendable warnings.-warnings-as-errorsto only our own targets (reminders,RemindersLibrary) viaswiftSettingsinPackage.swift, instead of the whole build, so future warnings in third-party dependencies won't break the build again.listNameCompletionoff the now-deprecated single-argument.custom(...)completion closure to the three-parameter signature required by the newer ArgumentParser.Test plan
make build-releasesucceeds and produces a working universal (arm64/x86_64) binaryswift testruns (3 pre-existing, unrelatedNaturalLanguageTestsfailures due toCalendar/NSDataDetectorbehavior differences on this OS/locale — not touched by this change)