Skip to content

Remove extra warning when require fails #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 1 commit into from
Sep 20, 2026
Merged

Remove extra warning when require fails #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/jar_dependencies.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,6 @@ def do_require(group_id, artifact_id, version, classifier)
require jar
end
rescue LoadError => e
Jars.warn "failed to load jar: #{jar} (#{e.message})"
Jars.debug(e)
raise JarLoadError, "failed to load jar: #{jar}; run `lock_jars` or reinstall the gem"
end
Expand Down
1 change: 0 additions & 1 deletion specs/jars_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ def fake.lock_down(...)
_(error).must_be_kind_of LoadError
_(error.message).must_equal 'failed to load jar: org/something/slf4j-simple/1.6.6/slf4j-simple-1.6.6.jar; ' \
'run `lock_jars` or reinstall the gem'
_($stderr.string).must_include 'failed to load jar: org/something/slf4j-simple/1.6.6/slf4j-simple-1.6.6.jar'
ensure
$stderr = STDERR
end
Expand Down
Loading