Remove extra warning when require fails - #113
Merged
Merged
Conversation
headius
force-pushed
the
remove_failed_require_warning
branch
from
September 20, 2026 10:33
36b343b to
8854853
Compare
This warning about a failed jar load is next to both * a debug of the original error * a re-raise of the original error as a JarLoadError I think it's unnecessary to also do a non-verbose warning about the failed load. The debug could possibly become a verbose warning, but an uncaught raised exception would log everything necessary and a caught raised exception probably indicates the caller does not want to see output. Fixes jruby#112
headius
force-pushed
the
remove_failed_require_warning
branch
from
September 20, 2026 10:39
8854853 to
5427749
Compare
headius
added a commit
to jruby/jruby
that referenced
this pull request
Sep 20, 2026
This removes the extraneous warning when require_jar fails. See jruby/jar-dependencies#113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This warning about a failed jar load is next to both
I think it's unnecessary to also do a non-verbose warning about the failed load. The debug could possibly become a verbose warning, but an uncaught raised exception would log everything necessary and a caught raised exception probably indicates the caller does not want to see output.
Fixes #112