Conversation
Signed-off-by: Divyansh Mishra <devmishrapro@gmail.com>
Contributor
|
/ok to test 595d4c3 |
Contributor
|
/ok to internal test 595d4c3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local validation
Platforms
Checks
Environment
Summary
Problem:
ensure_apiskipped a requested instance of a multiple-apply schema when another instance was already applied. For example, asking forPhysicsDriveAPI:transYafterPhysicsDriveAPI:transXreturned an invalid wrapper and lefttransYout of the prim'sapiSchemas.Solution: The helpers now check the requested API instance (using defined bool operator), and
Prim.ensure_apishares the scalar helper's logic.Testing
Added Regression tests that cover adding a second drive, mixed batches, and single-apply schemas. They also check that reusing an existing instance preserves its authored values without adding opinions to a stronger layer.