Skip to content

[Backport] PR #7977 to release/3.0.0 - #8001

Closed
isaaclab-bot[bot] wants to merge 1 commit into
release/3.0.0from
backport/release/3.0.0/pr-7977
Closed

isaaclab-bot[bot] wants to merge 1 commit into
release/3.0.0from
backport/release/3.0.0/pr-7977

Conversation

@isaaclab-bot

@isaaclab-bot isaaclab-bot Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Backports #7977 to release/3.0.0.

The original cherry-pick conflicted. An NVIDIA inference model proposed this resolution, and deterministic validation confirmed that it changes no paths outside the original PR. Because conflict resolution cannot be certified as an exact patch replay, this PR is intentionally a draft and requires release-maintainer review.

Field Commit
Original merged change 1e520e9d5cb44f54b70190f704f9d3dd634fa60f
Release base used 9ef05c8972634889968b332bfc4b80860789c3ff
Proposed backport 927387e87aa9067bbe07a74264c0f9e79743a133

@github-actions github-actions Bot added documentation Improvements or additions to documentation isaac-lab Related to Isaac Lab team labels Sep 24, 2026
@StafaH

StafaH commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #8002, which backports #7977 together with its rendering transform dependency #7941 to release/3.0.0.

@StafaH StafaH closed this Sep 24, 2026
StafaH added a commit that referenced this pull request Sep 24, 2026
…#7941, #7977, #7983, #7991, #8003) (#8002)

## Description

Backports the rendering changes and related release fixes:

- #7941 — routes rigid rendering transforms through `SceneDataProvider`
and preserves shared Fabric bindings.
- #7977 — batches due camera captures by renderer and fixes moving and
cloned camera updates. This supersedes #8001.
- #7983 — removes `CameraRenderSpec.camera_path_relative_to_env_0` and
derives and validates the OVRTX source camera path from
`camera_prim_paths`. The rendering changes were developed with this
interface, so it is required by their OVRTX tests.
- #7991 — fixes Newton's deprecated joint friction writers and the PhysX
rigid object collection `body_mask` writer signatures.
- #8003 — consolidates redundant Newton tests to shorten the Newton CI
job without changing runtime code.

#7941 required conflict resolution in the OVRTX legacy and OvStage
transform binding functions: the release branch's Newton model path
collection was replaced by SDP-published paths. #7983 was then
integrated with those SDP paths. Each added commit records its source
commit.

Custom scene-data backends must follow the `transforms_version`
publication contract described in the included migration documentation.
Direct callers of `BaseRenderer.render()` must pass a sequence, for
example `render([data])`. Callers constructing `CameraRenderSpec` must
remove the `camera_path_relative_to_env_0` argument; OVRTX now derives
it from `camera_prim_paths`.

## Validation

- Rendering and scene-data focused tests from the original backport
passed locally: 27 renderer tests and 50 scene-data / PhysX renderer
tests. OVRTX runtime cases were skipped locally because the optional
`ovrtx` module is unavailable.
- #7991: the Newton deprecated friction writer test passed, and 72 rigid
object collection mask writer cases passed. The new friction test fails
without the fix and passes with it.
- #8003: all 8 revised contact lifecycle cases passed. Kit-based Newton
asset tests remain for CI.
- `uv run isaaclab -f` passed after all additions with the changelog
base set to `release/3.0.0`, as did `git diff --check`.
- The original backport's documentation build passed with warnings
treated as errors. Full GPU and Kit CI is running on the updated PR.

## Type of change

- Rendering bug fixes and performance improvement
- Backend API bug fixes and breaking renderer / scene-data interface
changes with migration guidance
- Newton test consolidation
- Documentation and changelog fragments for affected source packages

## Release backport

This PR targets `release/3.0.0`; no further backport is needed.

## Checklist

- [x] Contribution guidance reviewed
- [x] Focused local tests and formatting checks passed
- [x] Public documentation and package changelog fragments included
- [ ] Full GPU and Kit CI passed

---------

Co-authored-by: ooctipus <zhengyuz@nvidia.com>
Co-authored-by: Piotr Barejko <pbarejko@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants