Conversation
|
run-ci |
|
There was a problem hiding this comment.
Isaac Lab Review Bot
The patch centralizes canonical-to-camera-scoped RenderVar key resolution in _get_render_var and applies it across image AOV and segmentation metadata consumers, addressing OVRTX 0.5 per-camera scopes without adding renderer state.
- Design and architecture: Keeping
RENDER_VAR_FRAME_KEYScanonical and performing scope resolution at the camera-specific consumption point preserves the existing version-compatibility separation. Source-name keys used by OVRTX 0.4 remain unchanged, while canonical/Render/...paths are resolved from the existing render-product scope. - API: No public APIs, exports, defaults, or compatibility-map values change. The compat documentation is clarified, and the user-visible fix has the required
isaaclab_ovchangelog fragment. - Implementation: All affected frame lookups are routed through the helper, and the added regression test verifies scoped LdrColor lookup through frame processing. The missing-instance-map diagnostic continues to report canonical logical RenderVar names alongside available authored keys; using resolved names could improve diagnostics, but the current message remains actionable and does not affect lookup correctness.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Description
Fixes empty OVRTX 0.5 camera outputs caused by the interaction between #7860 and #7861.
OVRTX 0.4 keys
frame.render_varsby source name, while OVRTX 0.5 keys it by the authored RenderVar prim path. After #7860 introduced per-camera render scopes, RenderVars were authored under/RenderCamera_<id>/Vars/..., but lookups still used canonical/Render/Vars/...paths.This patch minimally resolves those canonical keys against each camera’s existing
render_product_path. It covers all image AOV and segmentation-metadata lookups without adding renderer state or changing public APIs.Supersedes #7943 with a smaller implementation.
Type of change
Release backport
developChecklist
Docker and GPU tests run on demand. Push the commits you want tested, then
comment
run-cion the pull request.pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there