Skip to content

Fix OVRTX 0.5 RenderVar lookups for per-camera scopes - #7951

Closed
nvsekkin wants to merge 1 commit into
isaac-sim:developfrom
nvsekkin:esekkin/patch-rendervar
Closed

nvsekkin wants to merge 1 commit into
isaac-sim:developfrom
nvsekkin:esekkin/patch-rendervar

Conversation

@nvsekkin

@nvsekkin nvsekkin commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Fixes empty OVRTX 0.5 camera outputs caused by the interaction between #7860 and #7861.

OVRTX 0.4 keys frame.render_vars by source name, while OVRTX 0.5 keys it by the authored RenderVar prim path. After #7860 introduced per-camera render scopes, RenderVars were authored under /RenderCamera_<id>/Vars/..., but lookups still used canonical /Render/Vars/... paths.

This patch minimally resolves those canonical keys against each camera’s existing render_product_path. It covers all image AOV and segmentation-metadata lookups without adding renderer state or changing public APIs.

Supersedes #7943 with a smaller implementation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Release backport

  • Backport this pull request to the active release branch after it merges into develop

Checklist

Docker and GPU tests run on demand. Push the commits you want tested, then
comment run-ci on the pull request.

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (do not edit CHANGELOG.rst or bump extension.toml — CI handles that)
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Sep 22, 2026
@nvsekkin nvsekkin changed the title fix(ov): Resolve scoped OVRTX render vars Fix scoped OVRTX render vars Sep 22, 2026
@nvsekkin nvsekkin changed the title Fix scoped OVRTX render vars Fix OVRTX 0.5 RenderVar lookups for per-camera scopes Sep 22, 2026
@nvsekkin

Copy link
Copy Markdown
Collaborator Author

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Sep 22, 2026
@nvsekkin
nvsekkin marked this pull request as ready for review September 22, 2026 19:10
@nvsekkin
nvsekkin requested a review from a team September 22, 2026 19:10
@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with scoped and legacy RenderVar lookup behavior consistently covered.

Summary

This PR fixes OVRTX 0.5 camera output lookup by resolving canonical RenderVar paths against each camera’s authored render scope.

  • Adds a shared resolver for image AOV and segmentation-metadata lookups.
  • Preserves OVRTX 0.4 source-name lookup behavior.
  • Adds contract coverage for camera-scoped OVRTX 0.5 keys and documents the fix in the changelog.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[Canonical key<br/>/Render/Vars/LdrColor] --> B[Read camera render product<br/>/RenderCamera_7/RenderProduct]
    B --> C[Derive camera scope<br/>/RenderCamera_7]
    A --> D[Replace canonical scope]
    C --> D
    D --> E[Scoped frame key<br/>/RenderCamera_7/Vars/LdrColor]
    E --> F[frame.render_vars lookup]
Loading

Reviews (1) · Last reviewed commit: "fix(ov): Resolve scoped OVRTX render var..."

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The patch centralizes canonical-to-camera-scoped RenderVar key resolution in _get_render_var and applies it across image AOV and segmentation metadata consumers, addressing OVRTX 0.5 per-camera scopes without adding renderer state.

  • Design and architecture: Keeping RENDER_VAR_FRAME_KEYS canonical and performing scope resolution at the camera-specific consumption point preserves the existing version-compatibility separation. Source-name keys used by OVRTX 0.4 remain unchanged, while canonical /Render/... paths are resolved from the existing render-product scope.
  • API: No public APIs, exports, defaults, or compatibility-map values change. The compat documentation is clarified, and the user-visible fix has the required isaaclab_ov changelog fragment.
  • Implementation: All affected frame lookups are routed through the helper, and the added regression test verifies scoped LdrColor lookup through frame processing. The missing-instance-map diagnostic continues to report canonical logical RenderVar names alongside available authored keys; using resolved names could improve diagnostics, but the current message remains actionable and does not affect lookup correctness.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants