Gate checkout-only CLI tests with source_checkout_root - #7945
diegoferigo-rai wants to merge 1 commit into
Conversation
|
@StafaH patches from conda-forge/staged-recipes#34602 |
There was a problem hiding this comment.
Isaac Lab Review Bot
The change consistently gates checkout-dependent CLI tests with the existing source_checkout_root fixture, allowing installed-package test runs to skip tests that require repository-only files.
- Design and architecture: Centralizing checkout detection in the existing fixture matches the established test architecture. Class-level
usefixturesmarkers gate groups whose implementation paths may read the root project metadata; this is somewhat broad but not a merge-blocking concern. - API: No production APIs, public symbols, CLI arguments, or documented behavior change. The compatibility surface checked is limited to test access to repository launchers, root
pyproject.tomldata, and teleoperation scripts. - Implementation: Launcher copies and teleoperation script paths now resolve from the fixture-provided checkout root, with the teleoperation subprocess working directory updated consistently. Tests that indirectly read root project metadata are also gated, and the test-only
.skipchangelog fragment follows repository policy.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
|
Description
Some CLI unit tests still assume that they run from an Isaac Lab source checkout. They read the root
pyproject.toml, copy the repository launcher, or execute scripts that are not shipped in the installed package. This makes the tests fail when the suite is run against an installed wheel or conda package.Use the existing
source_checkout_rootfixture for these remaining tests, following the pattern introduced in #7389. The launcher and teleoperation tests also resolve checkout-only files from the path returned by the fixture.Type of change
Release backport
developChecklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched packageCONTRIBUTORS.mdor my name already exists thereLocal validation: