Skip to content

Gate checkout-only CLI tests with source_checkout_root - #7945

Open
diegoferigo-rai wants to merge 1 commit into
isaac-sim:developfrom
diegoferigo-rai:diegoferigo-rai/gate-checkout-only-cli-tests
Open

diegoferigo-rai wants to merge 1 commit into
isaac-sim:developfrom
diegoferigo-rai:diegoferigo-rai/gate-checkout-only-cli-tests

Conversation

@diegoferigo-rai

@diegoferigo-rai diegoferigo-rai commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Description

Some CLI unit tests still assume that they run from an Isaac Lab source checkout. They read the root pyproject.toml, copy the repository launcher, or execute scripts that are not shipped in the installed package. This makes the tests fail when the suite is run against an installed wheel or conda package.

Use the existing source_checkout_root fixture for these remaining tests, following the pattern introduced in #7389. The launcher and teleoperation tests also resolve checkout-only files from the path returned by the fixture.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Release backport

  • Backport this pull request to the active release branch after it merges into develop

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Local validation:

uvx pre-commit run --files <changed files>: passed
56 passed in 9.22s

@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Sep 22, 2026
@diegoferigo-rai
diegoferigo-rai marked this pull request as ready for review September 22, 2026 09:04
@diegoferigo-rai
diegoferigo-rai requested a review from a team September 22, 2026 09:04
@diegoferigo-rai

Copy link
Copy Markdown
Contributor Author

@StafaH patches from conda-forge/staged-recipes#34602

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The change consistently gates checkout-dependent CLI tests with the existing source_checkout_root fixture, allowing installed-package test runs to skip tests that require repository-only files.

  • Design and architecture: Centralizing checkout detection in the existing fixture matches the established test architecture. Class-level usefixtures markers gate groups whose implementation paths may read the root project metadata; this is somewhat broad but not a merge-blocking concern.
  • API: No production APIs, public symbols, CLI arguments, or documented behavior change. The compatibility surface checked is limited to test access to repository launchers, root pyproject.toml data, and teleoperation scripts.
  • Implementation: Launcher copies and teleoperation script paths now resolve from the fixture-provided checkout root, with the teleoperation subprocess working directory updated consistently. Tests that indirectly read root project metadata are also gated, and the test-only .skip changelog fragment follows repository policy.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the new fixture usage correctly limits checkout-dependent CLI tests without changing production behavior.

Summary

This PR consistently gates the remaining source-checkout-dependent CLI tests with the existing source_checkout_root fixture.

  • Launcher tests now copy platform launchers from the fixture-provided checkout root.
  • Install command tests that consume root dependency metadata skip cleanly outside a checkout.
  • Teleoperation help tests resolve repository-only scripts and their working directory through the fixture.
  • A skip changelog fragment records that the change is test-only.

Reviews (1) · Last reviewed commit: "Gate checkout-only CLI tests with source..."

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant