Conversation
|
run-ci |
There was a problem hiding this comment.
Isaac Lab Review Bot
The PR consistently raises the MJWarp line-search ceiling from 15/20 to 50 across the base rigid lift preset and the soft-body, cloth, and cable coupled presets, with a corresponding Isaac Lab Tasks changelog fragment.
- Design and architecture: The change remains within the existing PresetCfg and MJWarpSolverCfg layering. It updates only the rigid MJWarp solver entries while leaving coupled VBD solvers, preset ownership, default selections, and PhysX configurations unchanged.
- API: No public symbols, config field names, types, exports, or registrations change. The existing ls_iterations field is retuned, and the user-visible change is documented through the required package changelog fragment.
- Implementation: The four affected lift configurations now use a consistent ceiling of 50. Because line search may exit before reaching the ceiling, the principal residual tradeoff is increased worst-case solver work in non-converging states; the stated focused and rollout validation addresses the targeted warning and throughput scenario, though no automated regression test was added.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
|
| solver_cfg=MJWarpSolverCfg( | ||
| cone="elliptic", | ||
| ls_iterations=20, | ||
| ls_iterations=50, |
There was a problem hiding this comment.
Derived preset keeps old limit
The registered custom-coupling soft-lift task derives from this configuration but replaces the updated preset with its own MJWarpSolverCfg(ls_iterations=20). Contact states requiring more than 20 line-search iterations can therefore still exhaust the budget and emit the warnings this change is intended to eliminate. Please align that lift variant with the new ceiling or document why it must retain the lower limit.
Description
MuJoCo Warp now reports each world that exhausts its iterative line-search budget. The lift-task overrides of 15 and 20 iterations routinely hit this limit, causing thousands of device-side prints and significantly reducing simulation throughput.
This change raises the MJWarp line-search ceiling to the maintained default of 50 for rigid, soft-body, cloth, and cable lift configurations. Iterative line search exits when it converges, so environments that need fewer iterations do not execute the full ceiling.
A fixed-seed sweep of Kuka-Allegro found that 22 iterations still overflowed while 23 did not for that sample. The value 50 provides headroom for randomized contact states and trained-policy trajectories. A broader core-task audit also reproduced 2,213 warnings in the cloth task and 2,003 warnings in the cable task over 64 random-action steps at the old value of 20.
Upstream warning change: google-deepmind/mujoco_warp@283e05e
Type of change
Release backport
Screenshots
Not applicable.
Validation
Checklist