-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[4C/10] Route rigid rendering transforms through SDP #7941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ooctipus
merged 17 commits into
isaac-sim:develop
from
ooctipus:refactor/pr4c-sdp-transport
Sep 24, 2026
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
229f87d
Route rigid rendering transforms through SDP
ooctipus d648887
Preserve native Fabric bindings and authored scale
ooctipus 276c8b2
Consolidate Fabric requests and remove test-side synchronization
ooctipus 241fd86
Remove scene-data publication wrappers
ooctipus 3e788b0
Fix SDP changelog heading and test formatting
ooctipus 257e54d
Complete SDP Fabric propagation and remove redundant physics refreshes
ooctipus 494f215
Remove redundant rendering state and handle aliases
ooctipus c430897
Use Warp structs for Fabric bindings with a runtime backport
ooctipus 783fad8
Use the project-managed Warp without a Fabric backport
ooctipus daad5ec
Prune redundant renderer and scene-data tests
ooctipus ab0a410
Unify SDP transform reads under get_transforms
ooctipus 3feea0b
Separate native publication from Fabric rendering ownership
ooctipus 58104dc
Merge latest develop into SDP transport
ooctipus 42855f6
Keep transform publication versions producer-owned
ooctipus a8f50ae
Merge develop camera-path cleanup into SDP transport
ooctipus e4f5e7c
Move shared Fabric bindings into the Kit rendering integration
ooctipus 7a8da73
Identify the shared Fabric backend by stage and device
ooctipus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
source/isaaclab/changelog.d/sdp-transform-publication.major.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * **Breaking:** Added ``transforms_version`` to scene-data backends. Custom backends must initialize | ||
| it to zero and increment it after native pose writes or buffer swaps. SDP reads the existing | ||
| ``transforms`` property through ``get_transforms(output_format)`` without resetting the version. Backends | ||
| publishing multiple native formats may override that method and ``native_transform_formats``. | ||
| ``SceneDataProvider.get_transforms`` bound shared, | ||
| read-only arrays by default: matching layouts aliased native data and other layouts converted | ||
| once per publication. Callers requiring their own writable or preallocated arrays must pass | ||
| ``allow_passthrough=False``; this wrote directly into the supplied arrays without a staging copy. | ||
| * Routed rigid Fabric conversion through SDP while the Kit rendering integration owned destination binding and | ||
| GPU hierarchy propagation, preserving native PhysX publication and authored scale. Converted rigid destinations | ||
| became Fabric-only reset-stack roots so nested bodies retained their absolute physics poses. | ||
| Transform freshness no longer depended on the physics-step counter; | ||
| ``RenderContext.reset_scene_state_cadence`` remained available for geometry updates. | ||
| ``SimulationContext.fabric_cfg`` declared the shared native Fabric stage/device without allocating bindings. | ||
| * Used native Warp structs for Fabric transform bindings, relying on the project-managed Warp | ||
| dependency selected by Isaac Lab's Kit launch configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I like introducing Fabric stuff into the SDP - it goes kind of against the idea of the SDP being independent of any specific backend implementations.
Also, Fabric boils down to just
mat44das output, right? So, why do we need the other three fields here? 😅