Skip to content

[Tooling] Clean up VS Code recommendations - #7940

Open
StafaH wants to merge 1 commit into
isaac-sim:developfrom
StafaH:cleanup-vscode-recommendations
Open

StafaH wants to merge 1 commit into
isaac-sim:developfrom
StafaH:cleanup-vscode-recommendations

Conversation

@StafaH

@StafaH StafaH commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Description

Clean up the VS Code recommendations for the Isaac Lab checkout and generated external projects.

  • Keep the Python and Pylance extensions and recommend the Ruff extension used by the current formatter and linter configuration.
  • Remove the unused C/C++, ROS, MyST, spelling, Black, and Flake8 recommendations.
  • Remove the corresponding dead .tpp, Spell Right/cSpell, autoDocstring, and ROS Noetic settings from both settings templates.

This keeps the checked-in editor configuration aligned with the current Python and Ruff development workflow. No dependencies are added.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Release backport

  • Backport this pull request to the active release branch after it merges into develop

Screenshots

Not applicable.

Validation

  • uv run python -m pytest source/isaaclab_rl/test/test_template_generator.py (27 passed)
  • SKIP=check-changelog-fragments uv run isaaclab -f (all remaining hooks passed)

The unskipped changelog hook currently reports unrelated fragments already present on develop as modified relative to its comparison branch. This PR does not touch a source package, so no changelog fragment is required.

Checklist

  • I have read and understood the contribution guidelines.
  • I have run the complete pre-commit checks; the unrelated changelog baseline failure is described above.
  • Existing documentation already describes Python, Pylance, and Ruff as the supported editor workflow.
  • My changes generate no new warnings.
  • I have run the closest template-generator tests.
  • No source package is changed, so no changelog fragment is required.
  • My name already exists in CONTRIBUTORS.md.

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The PR consistently narrows VS Code recommendations to Python, Pylance, and Ruff while removing settings associated with the retired C++, spelling, autoDocstring, and ROS tooling from both checkout and external-project templates.

  • Design and architecture: The repository-level and generated external-project editor configurations are updated symmetrically, preserving the shared Python/Pylance/Ruff workflow without adding dependencies or changing source-package architecture.
  • API: No public Python API, CLI surface, or source package changes. The generated-project editor configuration does change intentionally by dropping obsolete recommendations and settings, while retained Python and Ruff keys remain consistent across both templates; no source-package changelog fragment or migration path is required.
  • Implementation: The added Ruff recommendation matches the retained ruff.configuration setting, and the removed settings correspond to tooling no longer recommended by these configurations. Contributors who independently install Spell Right or cSpell will no longer receive the repository-provided spelling configuration, which is an intentional non-blocking tradeoff of the cleanup.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@StafaH

StafaH commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Sep 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants