Conversation
StafaH
requested review from
AntoineRichard,
Toni-SM,
hujc7,
kellyguo11,
myurasov-nv and
ooctipus
as code owners
September 22, 2026 04:56
Contributor
There was a problem hiding this comment.
Isaac Lab Review Bot
The PR consistently narrows VS Code recommendations to Python, Pylance, and Ruff while removing settings associated with the retired C++, spelling, autoDocstring, and ROS tooling from both checkout and external-project templates.
- Design and architecture: The repository-level and generated external-project editor configurations are updated symmetrically, preserving the shared Python/Pylance/Ruff workflow without adding dependencies or changing source-package architecture.
- API: No public Python API, CLI surface, or source package changes. The generated-project editor configuration does change intentionally by dropping obsolete recommendations and settings, while retained Python and Ruff keys remain consistent across both templates; no source-package changelog fragment or migration path is required.
- Implementation: The added Ruff recommendation matches the retained ruff.configuration setting, and the removed settings correspond to tooling no longer recommended by these configurations. Contributors who independently install Spell Right or cSpell will no longer receive the repository-provided spelling configuration, which is an intentional non-blocking tradeoff of the cleanup.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Collaborator
Author
|
run-ci |
ooctipus
approved these changes
Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up the VS Code recommendations for the Isaac Lab checkout and generated external projects.
.tpp, Spell Right/cSpell, autoDocstring, and ROS Noetic settings from both settings templates.This keeps the checked-in editor configuration aligned with the current Python and Ruff development workflow. No dependencies are added.
Type of change
Release backport
developScreenshots
Not applicable.
Validation
uv run python -m pytest source/isaaclab_rl/test/test_template_generator.py(27 passed)SKIP=check-changelog-fragments uv run isaaclab -f(all remaining hooks passed)The unskipped changelog hook currently reports unrelated fragments already present on
developas modified relative to its comparison branch. This PR does not touch a source package, so no changelog fragment is required.Checklist
CONTRIBUTORS.md.