Conversation
|
There was a problem hiding this comment.
Isaac Lab Review Bot
The change narrowly adds pytetwild[all]>=0.3.0,<0.4 to the OVRTX cache warmer’s existing extra-package list, addressing the reported missing dependency without altering cache publication or job scheduling behavior.
- Design and architecture: The dependency is added within the existing
warm-ovrtx-cachejob; job boundaries, gating, concurrency, and cache handling remain unchanged. - API: The
extra-pip-packagesaction input remains a space-separated requirement string, with the existing OVRTX and PhysX pin outputs preserved. No public Isaac Lab API is affected. - Implementation: The requirement is bounded to the 0.3 release series and is placed alongside the warmer’s existing runtime dependencies. The GPU warmer was not executed locally, so successful installation and execution of the node IDs selected through
.github/test-subsets/postmerge-rendering.tomlremain to be confirmed by post-merge CI.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
| # The image's package set. Kit ships in the base image, so the teleop stack comes without the | ||
| # ``isaacsim`` wheel; ``teleop`` itself is left exactly as tuned. | ||
| ARG IMAGE_EXTRAS="--extra sb3 --extra skrl --extra rl-games --extra rsl-rl --extra viser --extra rerun --extra mimic --extra teleop --extra test" | ||
| ARG IMAGE_EXTRAS="--extra sb3 --extra skrl --extra rl-games --extra rsl-rl --extra viser --extra rerun --extra mimic --extra teleop --extra test --extra tetrahedralization" |
There was a problem hiding this comment.
image deps are cached across jobs so this would remove overhead.
another way this could be fixed is it could be layered in
- name: Layer CI test dependencies
RUN ${ISAACLAB_PATH}/isaaclab.sh -p -m pip install \
pytest pytest-mock junitparser flaky "coverage>=7.6.1 {tetrahedralization deps here}"
However, the docker change is much cleaner
|
run-ci |
|
Backported to |
## Description The OVRTX cache warmer's Franka soft-body tests fail during scene setup with `ModuleNotFoundError: No module named 'pytetwild'`. Install the existing `tetrahedralization` extra when building the shared base image so the warmer and other deformable tests inherit it from the cached image. Add `--extra tetrahedralization` to the image's existing frozen `uv sync` steps and remove the 12 duplicated `pytetwild` runtime requirements from the build workflow. The version range remains in `pyproject.toml`, and `uv.lock` selects the installed version. The existing dependency-image cache key already tracks both manifests and the Dockerfile, so dependency changes invalidate the cache automatically. Observed failure: https://github.com/isaac-sim/IsaacLab/actions/runs/35643651003/job/106478957632 ## Type of change - Bug fix (CI dependency) ## Validation - `uv run --extra test --frozen python -m pytest -q docker/test/test_dockerfile_nonroot.py docker/test/test_security_dependencies.py` — 36 tests and 11 subtests passed. - `uv run isaaclab -f` — all pre-commit checks passed using the existing validation environment and the upstream `develop` base for changelog validation. - Parsed and compared the workflow before and after the change: all 12 affected jobs use the base image, and all settings other than the removed package requirements are unchanged. - Exported the frozen `tetrahedralization` extra and verified it includes `pytetwild`, `pyvista`, and `vtk`. - `git diff --check` — passed. - The Docker image build and GPU warmer remain unverified locally; the dedicated warmer is skipped on pull-request events. ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` ## Checklist - [x] Read the contribution guidelines. - [x] Ran the repository formatting and lint checks. - [x] No changelog fragment required: only Docker and CI configuration changed. (cherry picked from commit a3e0295)
Description
The OVRTX cache warmer's Franka soft-body tests fail during scene setup with
ModuleNotFoundError: No module named 'pytetwild'. Install the existingtetrahedralizationextra when building the shared base image so the warmer and other deformable tests inherit it from the cached image.Add
--extra tetrahedralizationto the image's existing frozenuv syncsteps and remove the 12 duplicatedpytetwildruntime requirements from the build workflow. The version range remains inpyproject.toml, anduv.lockselects the installed version. The existing dependency-image cache key already tracks both manifests and the Dockerfile, so dependency changes invalidate the cache automatically.Observed failure: https://github.com/isaac-sim/IsaacLab/actions/runs/35643651003/job/106478957632
Type of change
Validation
uv run --extra test --frozen python -m pytest -q docker/test/test_dockerfile_nonroot.py docker/test/test_security_dependencies.py— 36 tests and 11 subtests passed.uv run isaaclab -f— all pre-commit checks passed using the existing validation environment and the upstreamdevelopbase for changelog validation.tetrahedralizationextra and verified it includespytetwild,pyvista, andvtk.git diff --check— passed.Release backport
developChecklist